Skip to content

acipher main.rs: Fix arg validation error messages#134

Merged
DemesneGH merged 1 commit intoapache:no-stdfrom
msgilligan:msgilligan/acipher-rs-fix-args
May 22, 2024
Merged

acipher main.rs: Fix arg validation error messages#134
DemesneGH merged 1 commit intoapache:no-stdfrom
msgilligan:msgilligan/acipher-rs-fix-args

Conversation

@msgilligan
Copy link
Copy Markdown
Contributor

@msgilligan msgilligan commented May 21, 2024

  • Subtract 1 from args.len() to get the number of arguments (arg[0] is program path/name)
  • Improve the "Correct usage" string to show a (more) standard synopsis
  • Improve the message when key size < 256 is specified.

Signed-off-by: Sean Gilligan sean@msgilligan.com

@msgilligan msgilligan force-pushed the msgilligan/acipher-rs-fix-args branch from fc82c21 to 26d176b Compare May 21, 2024 02:55
@msgilligan msgilligan marked this pull request as ready for review May 21, 2024 02:56
@b49020
Copy link
Copy Markdown
Contributor

b49020 commented May 21, 2024

Reviewed-by: Sumit Garg <sumit.garg@linaro.org>

@DemesneGH
Copy link
Copy Markdown
Contributor

Reviewed-by: Yuan Zhuang <yuanz@apache.org>

@DemesneGH
Copy link
Copy Markdown
Contributor

Ready to merge. @msgilligan Could you add the two tags above in commit message? thanks!

Signed-off-by: Sean Gilligan <sean@msgilligan.com>
Reviewed-by: Sumit Garg <sumit.garg@linaro.org>
Reviewed-by: Yuan Zhuang <yuanz@apache.org>
@msgilligan msgilligan force-pushed the msgilligan/acipher-rs-fix-args branch from 26d176b to b15f3be Compare May 22, 2024 02:25
@msgilligan
Copy link
Copy Markdown
Contributor Author

Ready to merge. @msgilligan Could you add the two tags above in commit message? thanks!

Done! Thank you!

@DemesneGH DemesneGH merged commit 1a25772 into apache:no-std May 22, 2024
@msgilligan msgilligan deleted the msgilligan/acipher-rs-fix-args branch May 22, 2024 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants