KAFKA-19938: Fix combined node log dir format in KafkaClusterTestKit #21017
+73
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@frankvicky @FrankYang0529 Can you take a look? Thanks |
FrankYang0529
approved these changes
Dec 3, 2025
Member
FrankYang0529
left a comment
FrankYang0529
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous logic did not format all log directories on combined nodes.
I was only formatting the metadata log directory which is the expected
result, all log directories should be formatted.
I stumble on this issue while implementing
KIP-1066
Reviewers: PoAn Yang [email protected]