Skip to content

Commit 735fd50

Browse files
authored
Bug: bad cache isolation between two sessions (#11083)
Port of Maven 3 bugfix to Maven 4 (deprecatd) `maven-embedder` module. Maven 4 by default is **not affected**, but this PR aligns Maven 3 and deprecated module in Maven 4. The "early" session used to load extension will populate cache in MavenExecutionRequest and same cache is later reused in "normal" session as well. This is wrong, as if project uses same parent POM as any of loaded extnsions, data loss in form of lost input locations occurs. Fixes #11081
1 parent 1f1b3ed commit 735fd50

File tree

1 file changed

+1
-0
lines changed
  • compat/maven-embedder/src/main/java/org/apache/maven/cli

1 file changed

+1
-0
lines changed

compat/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -964,6 +964,7 @@ private void encryption(CliRequest cliRequest) throws Exception {
964964

965965
private int execute(CliRequest cliRequest) throws MavenExecutionRequestPopulationException {
966966
MavenExecutionRequest request = executionRequestPopulator.populateDefaults(cliRequest.request);
967+
request.setRepositoryCache(new DefaultRepositoryCache()); // reset caches
967968

968969
if (cliRequest.request.getRepositoryCache() == null) {
969970
cliRequest.request.setRepositoryCache(new DefaultRepositoryCache());

0 commit comments

Comments
 (0)