[MNG-8311] empty but existing <localRepository/> in settings.xml (#1801)

danthe1st · web-flow · commit 9b9f72018194 · 2024-10-16T16:20:30.000+02:00
Use default when empty as well --- https://issues.apache.org/jira/browse/MNG-8311
diff --git a/maven-cli/src/main/java/org/apache/maven/cling/invoker/LookupInvoker.java b/maven-cli/src/main/java/org/apache/maven/cling/invoker/LookupInvoker.java
@@ -621,7 +621,7 @@ protected Path localRepositoryPath(C context) {
         }
         // settings
         userDefinedLocalRepo = context.effectiveSettings.getLocalRepository();
-        if (userDefinedLocalRepo != null) {
+        if (userDefinedLocalRepo != null && !userDefinedLocalRepo.isEmpty()) {
             return context.userResolver.apply(userDefinedLocalRepo);
         }
         // defaults

Original file line number	Diff line number	Diff line change
`@@ -621,7 +621,7 @@ protected Path localRepositoryPath(C context) {`
`621`	`621`	`}`
`622`	`622`	`// settings`
`623`	`623`	`userDefinedLocalRepo = context.effectiveSettings.getLocalRepository();`
`624`		`- if (userDefinedLocalRepo != null) {`
	`624`	`+ if (userDefinedLocalRepo != null && !userDefinedLocalRepo.isEmpty()) {`
`625`	`625`	`return context.userResolver.apply(userDefinedLocalRepo);`
`626`	`626`	`}`
`627`	`627`	`// defaults`