Fix unit tests

Author: gnodet

impl/maven-core/src/test/java/org/apache/maven/project/ResourceIncludeTest.java

@@ -200,7 +200,7 @@ void testTargetPathPreservedWithConnectedResource() {
 
         // Convert through DefaultSourceRoot to ensure targetPath extraction works
         DefaultSourceRoot sourceRootFromResource =
-                new DefaultSourceRoot(project.getBaseDirectory().toPath(), ProjectScope.MAIN, resourceWithTarget);
+                new DefaultSourceRoot(project.getBaseDirectory(), ProjectScope.MAIN, resourceWithTarget.getDelegate());
 
         project.addSourceRoot(sourceRootFromResource);
 
@@ -245,7 +245,7 @@ void testTargetPathEdgeCases() {
         // targetPath is null by default
 
         DefaultSourceRoot nullTargetSourceRoot =
-                new DefaultSourceRoot(project.getBaseDirectory().toPath(), ProjectScope.TEST, nullTargetResource);
+                new DefaultSourceRoot(project.getBaseDirectory(), ProjectScope.TEST, nullTargetResource.getDelegate());
         project.addSourceRoot(nullTargetSourceRoot);
 
         List<Resource> resources = project.getResources();
@@ -263,7 +263,7 @@ void testTargetPathEdgeCases() {
         placeholderResource.setTargetPath("${project.build.directory}/custom");
 
         DefaultSourceRoot placeholderSourceRoot =
-                new DefaultSourceRoot(project.getBaseDirectory().toPath(), ProjectScope.TEST, placeholderResource);
+                new DefaultSourceRoot(project.getBaseDirectory(), ProjectScope.TEST, placeholderResource.getDelegate());
         project.addSourceRoot(placeholderSourceRoot);
 
         Resource placeholderResult = project.getResources().stream()

impl/maven-impl/src/test/java/org/apache/maven/impl/DefaultSourceRootTest.java

@@ -19,13 +19,14 @@
 package org.apache.maven.impl;
 
 import java.nio.file.Path;
+import java.util.List;
 import java.util.Optional;
 
 import org.apache.maven.api.Language;
 import org.apache.maven.api.ProjectScope;
 import org.apache.maven.api.Session;
+import org.apache.maven.api.model.Resource;
 import org.apache.maven.api.model.Source;
-import org.apache.maven.model.Resource;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.extension.ExtendWith;
@@ -125,9 +126,10 @@ void testModuleTestDirectory() {
     @Test
     void testExtractsTargetPathFromResource() {
         // Test the Resource constructor that was broken in the regression
-        Resource resource = new Resource();
-        resource.setDirectory("src/test/resources");
-        resource.setTargetPath("test-output");
+        Resource resource = Resource.newBuilder()
+                .directory("src/test/resources")
+                .targetPath("test-output")
+                .build();
 
         DefaultSourceRoot sourceRoot = new DefaultSourceRoot(Path.of("myproject"), ProjectScope.TEST, resource);
 
@@ -143,8 +145,8 @@ void testExtractsTargetPathFromResource() {
     @Test
     void testHandlesNullTargetPathFromResource() {
         // Test null targetPath handling
-        Resource resource = new Resource();
-        resource.setDirectory("src/test/resources");
+        Resource resource =
+                Resource.newBuilder().directory("src/test/resources").build();
         // targetPath is null by default
 
         DefaultSourceRoot sourceRoot = new DefaultSourceRoot(Path.of("myproject"), ProjectScope.TEST, resource);
@@ -157,9 +159,10 @@ void testHandlesNullTargetPathFromResource() {
     @Test
     void testHandlesEmptyTargetPathFromResource() {
         // Test empty string targetPath
-        Resource resource = new Resource();
-        resource.setDirectory("src/test/resources");
-        resource.setTargetPath("");
+        Resource resource = Resource.newBuilder()
+                .directory("src/test/resources")
+                .targetPath("")
+                .build();
 
         DefaultSourceRoot sourceRoot = new DefaultSourceRoot(Path.of("myproject"), ProjectScope.TEST, resource);
 
@@ -171,9 +174,10 @@ void testHandlesEmptyTargetPathFromResource() {
     @Test
     void testHandlesPropertyPlaceholderInTargetPath() {
         // Test property placeholder preservation
-        Resource resource = new Resource();
-        resource.setDirectory("src/main/resources");
-        resource.setTargetPath("${project.build.directory}/custom");
+        Resource resource = Resource.newBuilder()
+                .directory("src/test/resources")
+                .targetPath("${project.build.directory}/custom")
+                .build();
 
         DefaultSourceRoot sourceRoot = new DefaultSourceRoot(Path.of("myproject"), ProjectScope.MAIN, resource);
 
@@ -186,7 +190,7 @@ void testHandlesPropertyPlaceholderInTargetPath() {
     @Test
     void testResourceConstructorRequiresNonNullDirectory() {
         // Test that null directory throws exception
-        Resource resource = new Resource();
+        Resource resource = Resource.newBuilder().build();
         // directory is null by default
 
         assertThrows(
@@ -199,12 +203,13 @@ void testResourceConstructorRequiresNonNullDirectory() {
     @Test
     void testResourceConstructorPreservesOtherProperties() {
         // Test that other Resource properties are correctly preserved
-        Resource resource = new Resource();
-        resource.setDirectory("src/test/resources");
-        resource.setTargetPath("test-classes");
-        resource.setFiltering("true");
-        resource.addInclude("*.properties");
-        resource.addExclude("*.tmp");
+        Resource resource = Resource.newBuilder()
+                .directory("src/test/resources")
+                .targetPath("test-classes")
+                .filtering("true")
+                .includes(List.of("*.properties"))
+                .excludes(List.of("*.tmp"))
+                .build();
 
         DefaultSourceRoot sourceRoot = new DefaultSourceRoot(Path.of("myproject"), ProjectScope.TEST, resource);