Skip to content

Commit 67232c7

Browse files
authored
Merge pull request #8930 from mbien/missing-record-label_delivery
UnusedDetector: add missing RECORD label
2 parents 67dcfc1 + ccfbd96 commit 67232c7

File tree

2 files changed

+51
-1
lines changed

2 files changed

+51
-1
lines changed

java/java.editor.base/src/org/netbeans/modules/java/editor/base/semantic/UnusedDetector.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -338,7 +338,7 @@ public boolean isDependencies() {
338338
typeElement = info.getElementUtilities().enclosingTypeElement(el);
339339
searchKinds = EnumSet.of(ClassIndex.SearchKind.METHOD_REFERENCES);
340340
}
341-
case ANNOTATION_TYPE, CLASS, ENUM, INTERFACE -> {
341+
case ANNOTATION_TYPE, CLASS, ENUM, RECORD, INTERFACE -> {
342342
List<? extends TypeElement> topLevelElements = info.getTopLevelElements();
343343
if (topLevelElements.size() == 1 && topLevelElements.get(0) == el) {
344344
return false;

java/java.hints/test/unit/src/org/netbeans/modules/java/hints/bugs/UnusedTest.java

Lines changed: 50 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,4 +85,54 @@ public void testUnusedNoPackagePrivate() throws Exception {
8585
.run(Unused.class)
8686
.assertWarnings();
8787
}
88+
89+
public void testNoFixForTopLevelPackagePrivateClass() throws Exception {
90+
HintTest.create()
91+
.input(
92+
"""
93+
package test;
94+
class Test {
95+
}
96+
""")
97+
.run(Unused.class)
98+
.assertWarnings();
99+
}
100+
101+
public void testNoFixForTopLevelPackagePrivateEnum() throws Exception {
102+
HintTest.create()
103+
.input(
104+
"""
105+
package test;
106+
enum Test {
107+
}
108+
""")
109+
.run(Unused.class)
110+
.assertWarnings();
111+
}
112+
113+
public void testNoFixForTopLevelPackagePrivateInterface() throws Exception {
114+
HintTest.create()
115+
.input(
116+
"""
117+
package test;
118+
interface Test {
119+
}
120+
""")
121+
.run(Unused.class)
122+
.assertWarnings();
123+
}
124+
125+
public void testNoFixForTopLevelPackagePrivateRecord() throws Exception {
126+
HintTest.create()
127+
.sourceLevel(17)
128+
.input(
129+
"""
130+
package test;
131+
record Test() {
132+
}
133+
""")
134+
.run(Unused.class)
135+
.assertWarnings();
136+
}
137+
88138
}

0 commit comments

Comments
 (0)