Skip to content

Commit d433663

Browse files
committed
Update mvn references to ./mvnw
1 parent d1968b9 commit d433663

File tree

12 files changed

+39
-39
lines changed

12 files changed

+39
-39
lines changed

.github/workflows/ci-hadoop2.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,14 +43,14 @@ jobs:
4343
bash dev/ci-before_install.sh
4444
- name: install
4545
run: |
46-
EXTRA_JAVA_TEST_ARGS=$(mvn help:evaluate -Dexpression=extraJavaTestArgs -q -DforceStdout)
46+
EXTRA_JAVA_TEST_ARGS=$(./mvnw help:evaluate -Dexpression=extraJavaTestArgs -q -DforceStdout)
4747
export MAVEN_OPTS="$MAVEN_OPTS $EXTRA_JAVA_TEST_ARGS"
48-
mvn install --batch-mode -P hadoop2 -DskipTests=true -Dmaven.javadoc.skip=true -Dsource.skip=true -Djava.version=1.8
48+
./mvnw install --batch-mode -P hadoop2 -DskipTests=true -Dmaven.javadoc.skip=true -Dsource.skip=true -Djava.version=1.8
4949
- name: verify
5050
env:
5151
TEST_CODECS: ${{ matrix.codes }}
5252
JAVA_VERSION: ${{ matrix.java }}
5353
run: |
54-
EXTRA_JAVA_TEST_ARGS=$(mvn help:evaluate -Dexpression=extraJavaTestArgs -q -DforceStdout)
54+
EXTRA_JAVA_TEST_ARGS=$(./mvnw help:evaluate -Dexpression=extraJavaTestArgs -q -DforceStdout)
5555
export MAVEN_OPTS="$MAVEN_OPTS $EXTRA_JAVA_TEST_ARGS"
56-
mvn verify --batch-mode -P hadoop2 javadoc:javadoc
56+
./mvnw verify --batch-mode -P hadoop2 javadoc:javadoc

.github/workflows/ci-hadoop3.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,14 +44,14 @@ jobs:
4444
bash dev/ci-before_install.sh
4545
- name: install
4646
run: |
47-
EXTRA_JAVA_TEST_ARGS=$(mvn help:evaluate -Dexpression=extraJavaTestArgs -q -DforceStdout)
47+
EXTRA_JAVA_TEST_ARGS=$(./mvnw help:evaluate -Dexpression=extraJavaTestArgs -q -DforceStdout)
4848
export MAVEN_OPTS="$MAVEN_OPTS $EXTRA_JAVA_TEST_ARGS"
49-
mvn install --batch-mode -DskipTests=true -Dmaven.javadoc.skip=true -Dsource.skip=true -Djava.version=${{ matrix.java.maven }}
49+
./mvnw install --batch-mode -DskipTests=true -Dmaven.javadoc.skip=true -Dsource.skip=true -Djava.version=${{ matrix.java.maven }}
5050
- name: verify
5151
env:
5252
TEST_CODECS: ${{ matrix.codes }}
5353
JAVA_VERSION: ${{ matrix.java.setup }}
5454
run: |
55-
EXTRA_JAVA_TEST_ARGS=$(mvn help:evaluate -Dexpression=extraJavaTestArgs -q -DforceStdout)
55+
EXTRA_JAVA_TEST_ARGS=$(./mvnw help:evaluate -Dexpression=extraJavaTestArgs -q -DforceStdout)
5656
export MAVEN_OPTS="$MAVEN_OPTS $EXTRA_JAVA_TEST_ARGS"
57-
mvn verify --batch-mode javadoc:javadoc
57+
./mvnw verify --batch-mode javadoc:javadoc

.github/workflows/vector-plugins.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,14 +44,14 @@ jobs:
4444
bash dev/ci-before_install.sh
4545
- name: install
4646
run: |
47-
EXTRA_JAVA_TEST_ARGS=$(mvn help:evaluate -Dexpression=extraJavaTestArgs -q -DforceStdout)
47+
EXTRA_JAVA_TEST_ARGS=$(./mvnw help:evaluate -Dexpression=extraJavaTestArgs -q -DforceStdout)
4848
export MAVEN_OPTS="$MAVEN_OPTS $EXTRA_JAVA_TEST_ARGS"
49-
mvn install --batch-mode -Pvector-plugins -DskipTests=true -Dmaven.javadoc.skip=true -Dsource.skip=true -Djava.version=${{ matrix.java }} -pl parquet-plugins/parquet-encoding-vector,parquet-plugins/parquet-plugins-benchmarks -am
49+
./mvnw install --batch-mode -Pvector-plugins -DskipTests=true -Dmaven.javadoc.skip=true -Dsource.skip=true -Djava.version=${{ matrix.java }} -pl parquet-plugins/parquet-encoding-vector,parquet-plugins/parquet-plugins-benchmarks -am
5050
- name: verify
5151
env:
5252
TEST_CODECS: ${{ matrix.codes }}
5353
JAVA_VERSION: ${{ matrix.java }}
5454
run: |
55-
EXTRA_JAVA_TEST_ARGS=$(mvn help:evaluate -Dexpression=extraJavaTestArgs -q -DforceStdout)
55+
EXTRA_JAVA_TEST_ARGS=$(./mvnw help:evaluate -Dexpression=extraJavaTestArgs -q -DforceStdout)
5656
export MAVEN_OPTS="$MAVEN_OPTS $EXTRA_JAVA_TEST_ARGS"
57-
mvn verify --batch-mode -Pvector-plugins javadoc:javadoc -pl parquet-plugins/parquet-encoding-vector,parquet-plugins/parquet-plugins-benchmarks -am
57+
./mvnw verify --batch-mode -Pvector-plugins javadoc:javadoc -pl parquet-plugins/parquet-encoding-vector,parquet-plugins/parquet-plugins-benchmarks -am

README.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ export PATH="/usr/local/opt/thrift@0.20.0/bin:$PATH"
6363
Once protobuf and thrift are available in your path, you can build the project by running:
6464

6565
```
66-
LC_ALL=C mvn clean install
66+
LC_ALL=C ./mvnw clean install
6767
```
6868

6969
## Features
@@ -100,7 +100,7 @@ Parquet-Java has supported Java Vector API to speed up reading, to enable this f
100100
* Requiring the CPU to support instruction sets:
101101
* avx512vbmi
102102
* avx512_vbmi2
103-
* To build the jars: `mvn clean package -P vector-plugins`
103+
* To build the jars: `./mvnw clean package -P vector-plugins`
104104
* For Apache Spark to enable this feature:
105105
* Build parquet and replace the parquet-encoding-{VERSION}.jar on the spark jars folder
106106
* Build parquet-encoding-vector and copy parquet-encoding-vector-{VERSION}.jar to the spark jars folder
@@ -157,9 +157,9 @@ Hive integration is now deprecated within the Parquet project. It is now maintai
157157

158158
## Build
159159

160-
To run the unit tests: `mvn test`
160+
To run the unit tests: `./mvnw test`
161161

162-
To build the jars: `mvn package`
162+
To build the jars: `./mvnw package`
163163

164164
The build runs in [GitHub Actions](https://github.com/apache/parquet-java/actions):
165165
[![Build Status](https://github.com/apache/parquet-java/workflows/Test/badge.svg)](https://github.com/apache/parquet-java/actions)
@@ -207,7 +207,7 @@ To contribute a patch:
207207
1. Break your work into small, single-purpose patches if possible. It’s much harder to merge in a large change with a lot of disjoint features.
208208
2. Create a JIRA for your patch on the [Parquet Project JIRA](https://issues.apache.org/jira/browse/PARQUET).
209209
3. Submit the patch as a GitHub pull request against the master branch. For a tutorial, see the GitHub guides on forking a repo and sending a pull request. Prefix your pull request name with the JIRA name (ex: https://github.com/apache/parquet-java/pull/240).
210-
4. Make sure that your code passes the unit tests. You can run the tests with `mvn test` in the root directory.
210+
4. Make sure that your code passes the unit tests. You can run the tests with `./mvnw test` in the root directory.
211211
5. Add new unit tests for your code.
212212

213213
We tend to do fairly close readings of pull requests, and you may get a lot of comments. Some common issues that are not code structure related, but still important:

dev/finalize-release

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@
77
# to you under the Apache License, Version 2.0 (the
88
# "License"); you may not use this file except in compliance
99
# with the License. You may obtain a copy of the License at
10-
#
10+
#
1111
# http://www.apache.org/licenses/LICENSE-2.0
12-
#
12+
#
1313
# Unless required by applicable law or agreed to in writing,
1414
# software distributed under the License is distributed on an
1515
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
@@ -34,8 +34,8 @@ rc_tag="$release_tag-rc$2"
3434
new_development_version="$3-SNAPSHOT"
3535

3636
git tag -am "Release Apache Parquet $release_version" "$release_tag" "$rc_tag"
37-
mvn --batch-mode release:update-versions -DdevelopmentVersion="$new_development_version"
38-
mvn -pl . versions:set-property -Dproperty=previous.version -DnewVersion="$release_version"
37+
./mvnw --batch-mode release:update-versions -DdevelopmentVersion="$new_development_version"
38+
./mvnw -pl . versions:set-property -Dproperty=previous.version -DnewVersion="$release_version"
3939
git commit -am 'Prepare for next development iteration'
4040

4141
echo

dev/prepare-release.sh

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@
77
# to you under the Apache License, Version 2.0 (the
88
# "License"); you may not use this file except in compliance
99
# with the License. You may obtain a copy of the License at
10-
#
10+
#
1111
# http://www.apache.org/licenses/LICENSE-2.0
12-
#
12+
#
1313
# Unless required by applicable law or agreed to in writing,
1414
# software distributed under the License is distributed on an
1515
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
@@ -38,7 +38,7 @@ new_development_version="$release_version-SNAPSHOT"
3838

3939
tag="apache-parquet-$release_version-rc$2"
4040

41-
mvn release:clean
42-
mvn release:prepare -Dtag="$tag" "-DreleaseVersion=$release_version" -DdevelopmentVersion="$new_development_version"
41+
./mvnw release:clean
42+
./mvnw release:prepare -Dtag="$tag" "-DreleaseVersion=$release_version" -DdevelopmentVersion="$new_development_version"
4343

44-
echo "Finish staging binary artifacts by running: mvn release:perform"
44+
echo "Finish staging binary artifacts by running: ./mvnw release:perform"

parquet-benchmarks/README.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,21 +16,21 @@
1616
~ specific language governing permissions and limitations
1717
~ under the License.
1818
-->
19-
19+
2020
# Running Parquet Benchmarks
2121

22-
The Parquet benchmarks in this module are run using the
22+
The Parquet benchmarks in this module are run using the
2323
[OpenJDK Java Microbenchmarking Harness](http://openjdk.java.net/projects/code-tools/jmh/).
2424

2525
First, building the `parquet-benchmarks` module creates an uber-jar including the Parquet
2626
classes and all dependencies, and a main class to launch the JMH tool.
2727

2828
```
29-
mvn --projects parquet-benchmarks -amd -DskipTests -Denforcer.skip=true clean package
29+
./mvnw --projects parquet-benchmarks -amd -DskipTests -Denforcer.skip=true clean package
3030
```
3131

32-
JMH doesn't have the notion of "benchmark suites", but there are certain benchmarks that
33-
make sense to group together or to run in isolation during development. The
32+
JMH doesn't have the notion of "benchmark suites", but there are certain benchmarks that
33+
make sense to group together or to run in isolation during development. The
3434
`./parquet-benchmarks/run.sh` script can be used to launch all or some benchmarks:
3535

3636
```

parquet-benchmarks/run.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ EOF
6969
elif [ "$BENCHMARK" == "build" ]; then
7070

7171
# Shortcut utility to rebuild the benchmark module only.
72-
( cd $SCRIPT_PATH && mvn -amd -DskipTests -Denforcer.skip=true clean package )
72+
( cd $SCRIPT_PATH && ./mvnw -amd -DskipTests -Denforcer.skip=true clean package )
7373

7474
elif [ "$BENCHMARK" == "clean" ]; then
7575

parquet-benchmarks/src/main/java/org/apache/parquet/benchmarks/FilteringBenchmarks.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@
7777
* <a href="https://jmh.morethan.io">https://jmh.morethan.io</a>.
7878
*
7979
* <pre>
80-
* mvn clean package &amp;&amp; java -jar target/parquet-benchmarks.jar org.apache.parquet.benchmarks.FilteringBenchmarks -rf json
80+
* ./mvnw clean package &amp;&amp; java -jar target/parquet-benchmarks.jar org.apache.parquet.benchmarks.FilteringBenchmarks -rf json
8181
* </pre>
8282
*/
8383
@BenchmarkMode(SingleShotTime)

parquet-benchmarks/src/main/java/org/apache/parquet/benchmarks/NestedNullWritingBenchmarks.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@
5555
* <a href="https://jmh.morethan.io">https://jmh.morethan.io</a>.
5656
*
5757
* <pre>
58-
* mvn clean package &amp;&amp; java -jar target/parquet-benchmarks.jar org.apache.parquet.benchmarks.NestedNullWritingBenchmarks -rf json
58+
* ./mvnw clean package &amp;&amp; java -jar target/parquet-benchmarks.jar org.apache.parquet.benchmarks.NestedNullWritingBenchmarks -rf json
5959
* </pre>
6060
*/
6161
@BenchmarkMode(SingleShotTime)

0 commit comments

Comments
 (0)