Conversation
added 7 commits
March 23, 2018 14:46
# Conflicts: # plugins/notifier/sms.go # test/e2e/junit.xml
Codecov Report
@@ Coverage Diff @@
## master #315 +/- ##
=========================================
- Coverage 32.04% 31.74% -0.3%
=========================================
Files 14 14
Lines 980 989 +9
=========================================
Hits 314 314
- Misses 613 622 +9
Partials 53 53
Continue to review full report at Codecov.
|
tamalsaha
requested changes
Mar 23, 2018
| RegisterFailHandler(Fail) | ||
| SetDefaultEventuallyTimeout(TIMEOUT) | ||
|
|
||
| junitReporter := reporters.NewJUnitReporter("junit.xml") |
| gen() | ||
| die(call('GO15VENDOREXPERIMENT=1 ' + libbuild.GOC + ' install ./cmd/... ./test/...')) | ||
|
|
||
|
|
Contributor
Author
There was a problem hiding this comment.
keep previous one
test/e2e/framework/httpserver.go
Outdated
| } | ||
| } | ||
| } | ||
| return &http.Server{ |
Contributor
There was a problem hiding this comment.
Use httptest.NewServer https://golang.org/pkg/net/http/httptest/#Server
tamalsaha
approved these changes
Mar 27, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.