Skip to content

Disable admission controllers for webhook server#362

Merged
tamalsaha merged 1 commit intomasterfrom
x7
May 5, 2018
Merged

Disable admission controllers for webhook server#362
tamalsaha merged 1 commit intomasterfrom
x7

Conversation

@tamalsaha
Copy link
Copy Markdown
Contributor

Since 1.10 release admission options are enabled by default . This was not the case in 1.9 release. Admission plugins seem unnecessary for a webhook server. So, I am disabling it.

If this is left enabled, then RBAC permissions need to be updated accordingly.

- apiGroups:
  - admissionregistration.k8s.io
  resources:
    - mutatingwebhookconfigurations
    - validatingwebhookconfigurations
  verbs: ["get","list"]

Since [1.10 release](https://github.com/kubernetes/apiserver/blob/release-1.10/pkg/server/options/recommended.go#L43) admission options are enabled by default . This was not the case in 1.9 release. Admission plugins seem unnecessary for a webhook server. So, I am disabling it.

If this is left enabled, then RBAC permissions need to be updated accordingly.
```
- apiGroups:
  - admissionregistration.k8s.io
  resources:
    - mutatingwebhookconfigurations
    - validatingwebhookconfigurations
  verbs: ["get","list"]
```
@tamalsaha tamalsaha merged commit c064cf0 into master May 5, 2018
@tamalsaha tamalsaha requested a review from mirshahriar May 5, 2018 17:06
@tamalsaha tamalsaha deleted the x7 branch May 5, 2018 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant