Fixed parsing regression - unrecognized quoted args beginning with a hyphen no longer strip the hyphen.

Author: coreybutler

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@author.io/arg",
-  "version": "1.3.20",
+  "version": "1.3.21",
   "description": "An argument parser for CLI applications.",
   "main": "./src/index.js",
   "exports": {
@@ -55,7 +55,7 @@
   },
   "dev": {
     "alias": {
-      "@author.io/arg": "/app/.dist/@author.io/arg/index.js"
+      "@author.io/arg": "/app/.dist/arg/index.js"
     }
   },
   "standard": {

src/flag.js

@@ -24,7 +24,7 @@ export default class Flag {
     }
 
     this.#rawName = cfg.name
-    this.#name = cfg.name.replace(/^-+/gi, '').trim()
+    this.#name = cfg.name // .replace(/^-+/gi, '').trim()
 
     if (cfg.hasOwnProperty('description')) { // eslint-disable-line no-prototype-builtins
       this.#description = cfg.description

src/index.js

@@ -14,6 +14,7 @@ class Parser {
   #aliases = new Set()
   #validFlags = null
   #length = 0
+  #quotedFlags = new Set()
 
   #cleanFlag = flag => {
     return flag.replace(/^-+/g, '').trim().toLowerCase()
@@ -181,17 +182,18 @@ class Parser {
 
     // Normalize each flag/value pairing
     Array.from([...input.matchAll(PARSER)]).forEach(parsedArg => {
-      let { flag, value, unquoted_value, quoted_arg, arg } = parsedArg.groups
+      let { flag, value, unquoted_value, quoted_arg, arg } = parsedArg.groups // eslint-disable-line camelcase
 
       // If the arg attribute is present, add the
       // value to the arguments placeholder instead
       // of the flags
       if (arg) {
         args.push(arg)
-      } else if (quoted_arg) {
+      } else if (quoted_arg) { // eslint-disable-line camelcase
         args.push(quoted_arg)
+        this.#quotedFlags.add(this.#cleanFlag(quoted_arg))
       } else {
-        value = unquoted_value || value
+        value = unquoted_value || value // eslint-disable-line camelcase
         // Flags without values are considered boolean "true"
         value = value !== undefined ? value : true
 
@@ -236,7 +238,7 @@ class Parser {
         }
       }
 
-      if (typeof flag.value !== flag.type) {
+      if (typeof flag.value !== flag.type) { // eslint-disable-line valid-typeof
         if (flag.type === 'boolean') {
           if (flag.value === null) {
             flag.value = false
@@ -268,7 +270,8 @@ class Parser {
   addFlag (cfg) {
     cfg = typeof cfg === 'object' ? cfg : { name: cfg }
 
-    const clean = this.#cleanFlag(cfg.name)
+    const preclean = this.#cleanFlag(cfg.name)
+    const clean = this.#quotedFlags.has(preclean) ? cfg.name : preclean
 
     if (this.#flags.has(clean)) {
       throw new Error(`"${cfg.name}" flag already exists.`)

tests/09-regression.js

@@ -148,3 +148,12 @@ test('Boolean flags followed by unnamed string argument', t => {
 
   t.end()
 })
+
+test('Flags with hyphens should not strip hypen', t => {
+  const input = `session account api_profiles remove "-d1pkFXOnEmvbi-xwDJ8H"`
+  const { data } = new Parser(input)
+
+  t.expect(true, data['-d1pkFXOnEmvbi-xwDJ8H'], 'hyphenated argument recognized')
+
+  t.end()
+})