feat(events): fromApiDestinationAttributes import method#29943
feat(events): fromApiDestinationAttributes import method#29943mergify[bot] merged 5 commits intoaws:mainfrom
fromApiDestinationAttributes import method#29943Conversation
github-actions
bot
added
bug
aws-cdk-automation
left a comment
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
nmussy
changed the title
fromApiDestinationAttributes import method
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
| const ruleDescription = testCase.assertions.awsApiCall( | ||
| '@aws-sdk/client-eventbridge', | ||
| 'ListTargetsByRule', | ||
| { | ||
| Rule: ruleName, | ||
| EventBusName: 'default', | ||
| Limit: 1, | ||
| }, | ||
| ); |
There was a problem hiding this comment.
I was hoping to test the successful execution of the rule, but I couldn't find a super easy way to do it. Looking at the other integs for events-targets, running a ListTargetsByRule seems to be the standard, but let me know if you want more
aws-cdk-automation
added
the
pr/needs-community-review
GavinZZ
left a comment
GavinZZ
left a comment
There was a problem hiding this comment.
Nice, thanks for adding support for this functionality! Love it.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
aws-cdk-automation
removed
the
pr/needs-community-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one. |
3 participants
Issue # (if applicable)
Closes #29942
Reason for this change
Allows existing API Destinations to be imported and attached to additional rules
Description of changes
ApiDestination.fromApiDestinationAttributesmethodDescription of how you validated changes
Added unit and integ tests
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license