feat(efs): allow to specify az for one-zone#30010
Conversation
| // if props.vpcSubnets.availabilityZones is defined, select the first one as the zone otherwise | ||
| // the first AZ of the VPC. | ||
| const oneZoneAzName = props.vpcSubnets?.availabilityZones ? | ||
| props.vpcSubnets.availabilityZones[0] : props.vpc.availabilityZones[0]; |
There was a problem hiding this comment.
Maybe add a check for
props.vpc.availabilityZones.includes(props.vpcSubnets.availabilityZones[0])There was a problem hiding this comment.
Nice catch! I'll add it in. Thanks.
There was a problem hiding this comment.
OK this is a little tricky because vpc.availabilityZones could be dummy values if the context was not generated by the context provider. Let's only check that when we are confident they are neither dummy values nor unresolved tokens.
There was a problem hiding this comment.
Yeah good call, I only saw the unresolved tokens coming
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one. |
Issue # (if applicable)
This PR allows users to specify AZ for the one-zone filesystems through the
vpcSubnets.availabilityZones. Before this PR,vpcSubnetsis not allowed whenoneZoneis enabled, this PR removes the restriction and takes the following use cases into considerations:Closes #30005
Reason for this change
Description of changes
Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license