feat(appsync): add `maxBatchSize` property to the `AppSyncFunction` Construct by mazyu36 · Pull Request #30266 · aws/aws-cdk

mazyu36 · 2024-05-18T09:31:15Z

Issue # (if applicable)

N/A

Reason for this change

Missing property in the Construct.

https://docs.aws.amazon.com/ja_jp/AWSCloudFormation/latest/UserGuide/aws-resource-appsync-functionconfiguration.html#cfn-appsync-functionconfiguration-maxbatchsize

Description of changes

Add maxBatchSize property to the AppSyncFunction Construct

Description of how you validated changes

Add unit tests and integ tests.

Checklist

My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

lpizzinidev

Thanks 👍 Left comments for minor documentation adjustments

packages/aws-cdk-lib/aws-appsync/README.md

packages/aws-cdk-lib/aws-appsync/lib/appsync-function.ts

packages/aws-cdk-lib/aws-appsync/test/appsync-function.test.ts

packages/aws-cdk-lib/aws-appsync/lib/appsync-function.ts

Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>

mazyu36 · 2024-06-08T17:22:33Z

@lpizzinidev
Thank you always for your reviews!
I have addressed your comments.

lpizzinidev

Thanks 👍

aaythapa

Some clarifying questions

...s-cdk-testing/framework-integ/test/aws-appsync/test/integ.appsync-function-max-batch-size.ts

packages/aws-cdk-lib/aws-appsync/lib/appsync-function.ts

mazyu36 · 2024-06-11T00:17:56Z

@aaythapa
Thank you for the review.
I’ve addressed all your comments.

aaythapa

lgtm

mergify · 2024-06-11T16:26:10Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2024-06-11T16:30:09Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2024-06-11T23:23:13Z

update

✅ Branch has been successfully updated

mazyu36 · 2024-06-12T23:42:13Z

@Mergifyio update

mergify · 2024-06-12T23:42:26Z

update

✅ Branch has been successfully updated

aws-cdk-automation · 2024-06-13T00:13:41Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: a2124f3
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2024-06-13T00:13:55Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

…onstruct (aws#30266) ### Issue # (if applicable) N/A ### Reason for this change Missing property in the Construct. https://docs.aws.amazon.com/ja_jp/AWSCloudFormation/latest/UserGuide/aws-resource-appsync-functionconfiguration.html#cfn-appsync-functionconfiguration-maxbatchsize ### Description of changes Add `maxBatchSize` property to the `AppSyncFunction` Construct ### Description of how you validated changes Add unit tests and integ tests. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

aws-cdk-automation · 2024-07-25T21:07:22Z

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

feat: maxBatchSize added

5268f8f

aws-cdk-automation requested a review from a team May 18, 2024 09:31

github-actions bot added valued-contributor [Pilot] contributed between 6-12 PRs to the CDK p2 labels May 18, 2024

mazyu36 marked this pull request as ready for review May 18, 2024 11:03

github-actions bot mentioned this pull request May 20, 2024

Weekly PR metrics report #30274

Closed

Merge branch 'main' into appsync-function-maxbatchsize

1aa1a2b

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 23, 2024

github-actions bot mentioned this pull request Jun 1, 2024

Monthly PR metrics report #30414

Closed

lpizzinidev suggested changes Jun 8, 2024

View reviewed changes

aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 8, 2024

mazyu36 and others added 6 commits June 9, 2024 01:48

Update packages/aws-cdk-lib/aws-appsync/README.md

bc652df

Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>

Update packages/aws-cdk-lib/aws-appsync/lib/appsync-function.ts

faccca3

Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>

Update packages/aws-cdk-lib/aws-appsync/test/appsync-function.test.ts

e14f87e

Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>

Update packages/aws-cdk-lib/aws-appsync/lib/appsync-function.ts

a949deb

Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>

Update packages/aws-cdk-lib/aws-appsync/lib/appsync-function.ts

d7a71cf

Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>

chore: spacing

c21530b

lpizzinidev approved these changes Jun 9, 2024

View reviewed changes

aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jun 9, 2024

aaythapa reviewed Jun 10, 2024

View reviewed changes

chore: error message

4f364b8

aaythapa approved these changes Jun 11, 2024

View reviewed changes

aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jun 11, 2024

mergify bot added 2 commits June 11, 2024 16:58

Merge branch 'main' into appsync-function-maxbatchsize

ef790de

Merge branch 'main' into appsync-function-maxbatchsize

bcbbcfc

Merge branch 'main' into appsync-function-maxbatchsize

a2124f3

mergify bot merged commit f1dc142 into aws:main Jun 13, 2024

mazyu36 deleted the appsync-function-maxbatchsize branch June 18, 2024 14:37

This was referenced Jul 5, 2024

[Snyk] Upgrade: , aws-cdk NOUIY/aws-solutions-constructs#107

Open

[Snyk] Upgrade: , aws-cdk NOUIY/aws-solutions-constructs#108

Open

This was referenced Jul 16, 2024

[Snyk] Upgrade: , aws-cdk NOUIY/aws-solutions-constructs#109

Open

[Snyk] Upgrade: , aws-cdk NOUIY/aws-solutions-constructs#110

Open

NOUIY mentioned this pull request Jul 23, 2024

[Snyk] Upgrade: , aws-cdk NOUIY/aws-solutions-constructs#111

Open

aws locked as resolved and limited conversation to collaborators Jul 25, 2024

Conversation

mazyu36 commented May 18, 2024

Issue # (if applicable)

Reason for this change

Description of changes

Description of how you validated changes

Checklist

Uh oh!

lpizzinidev left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mazyu36 commented Jun 8, 2024

Uh oh!

lpizzinidev left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aaythapa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mazyu36 commented Jun 11, 2024

Uh oh!

aaythapa left a comment

Choose a reason for hiding this comment

Uh oh!

mergify bot commented Jun 11, 2024

Uh oh!

mergify bot commented Jun 11, 2024

Uh oh!

mergify bot commented Jun 11, 2024

✅ Branch has been successfully updated

Uh oh!

mazyu36 commented Jun 12, 2024

Uh oh!

mergify bot commented Jun 12, 2024

✅ Branch has been successfully updated

Uh oh!

aws-cdk-automation commented Jun 13, 2024

AWS CodeBuild CI Report

Uh oh!

mergify bot commented Jun 13, 2024

Uh oh!

aws-cdk-automation commented Jul 25, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

lpizzinidev left a comment •

edited

Loading