feat(stepfunctions-tasks): add workerType and numberOfWorkers to GlueStartJobRun class#30319
Merged
mergify[bot] merged 5 commits intoaws:mainfrom May 27, 2024
Merged
Conversation
github-actions
bot
added
the
valued-contributor
github-actions
bot
added
effort/small
aws-cdk-automation
added
the
pr/needs-maintainer-review
aaythapa
reviewed
May 24, 2024
packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/glue/start-job-run.ts
Outdated
Show resolved
Hide resolved
packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/glue/start-job-run.ts
Outdated
Show resolved
Hide resolved
packages/aws-cdk-lib/aws-stepfunctions-tasks/test/glue/start-job-run.test.ts
Outdated
Show resolved
Hide resolved
packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/glue/start-job-run.ts
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@aaythapa |
aaythapa
approved these changes
May 27, 2024
Contributor
aaythapa
left a comment
aaythapa
left a comment
There was a problem hiding this comment.
thanks for addressing the comments, lgtm
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
aws-cdk-automation
removed
the
pr/needs-maintainer-review
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
1 task
vdahlberg
pushed a commit
to vdahlberg/aws-cdk
that referenced
this pull request
Jun 10, 2024
…StartJobRun class (aws#30319) ### Issue # (if applicable) Closes aws#12757. ### Reason for this change Missing property ### Description of changes Add workerType and numberOfWorkers to GlueStartJobRun class. The reasons for this change are as follows: * AllocatedCapacity is deprecated. * MaxCapacity can only be used with Glue version 1 and earlier, which have already reached end of support (EOS). * Glue version 2 and later use WorkerType and NumberOfWorkers. For mor information, see also the documents below. https://docs.aws.amazon.com/glue/latest/dg/aws-glue-api-jobs-runs.html#aws-glue-api-jobs-runs-StartJobRun https://docs.aws.amazon.com/glue/latest/dg/glue-version-support-policy.html ### Description of how you validated changes Add unit tests and integ tests. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This was referenced Jun 29, 2024
This was referenced Jul 12, 2024
This was referenced Jul 19, 2024
Collaborator
|
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #12757.
Reason for this change
Missing property
Description of changes
Add workerType and numberOfWorkers to GlueStartJobRun class.
The reasons for this change are as follows:
For mor information, see also the documents below.
https://docs.aws.amazon.com/glue/latest/dg/aws-glue-api-jobs-runs.html#aws-glue-api-jobs-runs-StartJobRun
https://docs.aws.amazon.com/glue/latest/dg/glue-version-support-policy.html
Description of how you validated changes
Add unit tests and integ tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license