Skip to content

feat(fsx): add properties to enable automatic backups for Lustre file system#30343

Merged
mergify[bot] merged 7 commits intoaws:mainfrom
mazyu36:fsx-lustre-backup-settings
Jun 21, 2024
Merged

feat(fsx): add properties to enable automatic backups for Lustre file system#30343
mergify[bot] merged 7 commits intoaws:mainfrom
mazyu36:fsx-lustre-backup-settings

Conversation

@mazyu36
Copy link
Copy Markdown
Contributor

@mazyu36 mazyu36 commented May 26, 2024 •
edited
Loading

Issue # (if applicable)

Closes #30340.

Reason for this change

Current LustreFileSystem class does not support automatic backups.

Description of changes

Add properties equivalent to those of the L1 construct to the L2 construct.

Segregated the dailyAutomaticBackupStartTime as a class to enable its usage in another file system's L2 construct (for example, Ontap) in the future.

Description of how you validated changes

Add unit tests and integ tests.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added p2 valued-contributor [Pilot] contributed between 6-12 PRs to the CDK labels May 26, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team May 26, 2024 09:11
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 26, 2024
@github-actions github-actions bot mentioned this pull request May 27, 2024
Closed
@ashishdhingra
Copy link
Copy Markdown
Contributor

ashishdhingra commented May 28, 2024 •
edited
Loading

@mazyu36 Thanks for the PR. Looks like property driveCacheType is also missing from L2 LustreConfiguration. Could you please review?

@mazyu36
Copy link
Copy Markdown
Contributor Author

mazyu36 commented May 28, 2024 •
edited
Loading

@ashishdhingra
Thank you for your comment. You're correct that driveCacheType does not exist either. However, this item is not related to backups and is related to the storage type.

This parameter is required when storage type is HDD.

Therefore, I think it would be preferable to address it either in #30207, which is adding the storage type, or in a separate PR.

Please let me know if you have any other thoughts or suggestions.​​​​​​​​​​​​​​​​

@github-actions github-actions bot mentioned this pull request Jun 1, 2024
Closed
@comcalvi
Copy link
Copy Markdown
Contributor

comcalvi commented Jun 20, 2024

Nice work!

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 20, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

comcalvi
comcalvi previously requested changes Jun 20, 2024
View reviewed changes
...s-cdk-testing/framework-integ/test/aws-fsx/test/integ.lustre-file-system-automatic-backup.ts Outdated
testCases: [stack],
});

app.synth();
Copy link
Copy Markdown
Contributor

@comcalvi comcalvi Jun 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this line

Copy link
Copy Markdown
Contributor Author

@mazyu36 mazyu36 Jun 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@comcalvi
Thanks. I removed it.

@comcalvi
Copy link
Copy Markdown
Contributor

comcalvi commented Jun 20, 2024

almost missed it, but no need for the app.synth() line in the integ test. Other than that this is ready to merge.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 20, 2024
@mergify mergify bot dismissed comcalvi’s stale review June 20, 2024 22:25

Pull request has been modified.

@mazyu36
Copy link
Copy Markdown
Contributor Author

mazyu36 commented Jun 20, 2024

@comcalvi
Thank you for the review!
I've addressed the comment.

@mazyu36 mazyu36 requested a review from comcalvi June 20, 2024 23:24
comcalvi
comcalvi approved these changes Jun 21, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@comcalvi comcalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! Nice work.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 21, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mazyu36
Copy link
Copy Markdown
Contributor Author

mazyu36 commented Jun 21, 2024

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 21, 2024

update

✅ Branch has been successfully updated

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Jun 21, 2024

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: a03710c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 21, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 3b95777 into aws:main Jun 21, 2024
@mazyu36 mazyu36 deleted the fsx-lustre-backup-settings branch June 22, 2024 06:23
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Jul 25, 2024

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@comcalvi comcalvi comcalvi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

p2 valued-contributor [Pilot] contributed between 6-12 PRs to the CDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fsx: enable automatic backup settings for Lustre file system

4 participants

@mazyu36 @ashishdhingra @comcalvi @aws-cdk-automation