fix(s3-notifications): unable to delete the existing S3 event notifications (under feature flag) by sarangarav · Pull Request #30610 · aws/aws-cdk

sarangarav · 2024-06-21T07:24:47Z

Issue # (if applicable)

Reason for this change

Fix to address the issues deleting the existing S3 event notifications and adding new event notifications on top of existing notifications.

Description of changes

We fixed the hashing logic used to identify old vs external S3 event notifications

Description of how you validated changes

Manually tested, integration and unit tested the changes

yes

Checklist

My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

…ations

aws-cdk-automation

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

…ations

sarangarav · 2024-06-24T03:13:46Z

packages/aws-cdk-lib/aws-s3/lib/notifications-resource/notifications-resource-handler.ts

+    // Removing lines that starts with '#' (comment lines)
    const handlerSourceWithoutComments = handlerSource.replace(/^ *#.*\n?/gm, '');

-    if (handlerSourceWithoutComments.length > 4096) {


Inline function code can now exceed 4096 bytes. It can support up to 4MB now.

Latest public documentation: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-lambda-function-code.html#cfn-lambda-function-code-zipfile

GavinZZ

Left some feedbacks

packages/@aws-cdk/custom-resource-handlers/lib/aws-s3/notifications-resource-handler/index.py

packages/aws-cdk-lib/aws-s3/lib/notifications-resource/notifications-resource.ts

Pull request has been modified.

…olved conflicts

GavinZZ · 2024-06-25T20:30:12Z

@mergify update

mergify · 2024-06-25T20:30:21Z

update

☑️ Nothing to do

Details

#commits-behind>0 [📌 update requirement]
-closed [📌 update requirement]
-conflict [📌 update requirement]
queue-position=-1 [📌 update requirement]

sarangarav · 2024-06-26T01:34:20Z

@mergify update

mergify · 2024-06-26T01:34:28Z

update

☑️ Nothing to do

Details

#commits-behind>0 [📌 update requirement]
-closed [📌 update requirement]
-conflict [📌 update requirement]
queue-position=-1 [📌 update requirement]

mergify · 2024-06-26T17:25:02Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

…nts-notifications

Pull request has been modified.

mergify · 2024-06-26T19:57:21Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2024-06-26T20:01:33Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

sarangarav · 2024-06-26T20:05:38Z

@Mergifyio refresh

mergify · 2024-06-26T20:05:50Z

refresh

✅ Pull request refreshed

Pull request has been modified.

aws-cdk-automation · 2024-06-26T20:40:10Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: b586a30
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2024-06-26T20:40:31Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

… notifications (under feature flag) (#30699) Reverts #30610 due to Feature flags issues

aws-cdk-automation · 2024-07-25T17:45:28Z

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

Raviteja Saranga added 2 commits June 21, 2024 01:51

Bug fix to address the issues deleting existing S3 event notifications

cbdf720

Bug fix to address the issues with deleting existing S3 event notific…

e882c5c

…ations

github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. effort/medium Medium work item – several days of effort p1 labels Jun 21, 2024

aws-cdk-automation requested a review from a team June 21, 2024 07:25

aws-cdk-automation previously requested changes Jun 21, 2024

View reviewed changes

sarangarav changed the title ~~Feature/s3 lambda events notifications~~ fix(s3-notifications): unable to delete the existing S3 event notifications (under feature flag) Jun 21, 2024

sarangarav requested a review from aws-cdk-automation June 21, 2024 07:28

paulhcsun mentioned this pull request Jun 21, 2024

fix(s3-notifications): unable to delete the existing S3 event notifications (under feature flag) #30527

Closed

1 task

Raviteja Saranga and others added 4 commits June 21, 2024 13:49

Bug fix to address the issues with deleting existing S3 event notific…

d4861bb

…ations

Merge branch 'main' into feature/s3-lambda-events-notifications

a2dbea9

Merge branch 'main' into feature/s3-lambda-events-notifications

0bcda02

Bug fix to address the issues with deleting existing S3 event notific…

87f5b6b

…ations

sarangarav commented Jun 24, 2024

View reviewed changes

Raviteja Saranga added 3 commits June 23, 2024 23:10

Update S3-notification integ tests snapshot

fc233f8

Update S3-notification integ tests snapshot

3d4190c

Update S3 notification resource handler

52f4e8a

github-actions bot mentioned this pull request Jun 24, 2024

Weekly PR metrics report #30637

Closed

Raviteja Saranga added 2 commits June 24, 2024 08:18

Fix S3 event notifications lint errors

e666f0a

Update S3-notification integ tests

00aad4a

GavinZZ previously requested changes Jun 24, 2024

View reviewed changes

Update S3 event notification integ tests

8c6971f

Raviteja Saranga added 2 commits June 25, 2024 14:30

Merge origin/main into feature/s3-lambda-events-notifications and res…

08ce15f

…olved conflicts

Fix the S3 event notifications issues

c506d5e

Update S3 event notifications integ tests

10b804c

aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jun 26, 2024

GavinZZ previously approved these changes Jun 26, 2024

View reviewed changes

Merge remote-tracking branch 'origin/main' into feature/s3-lambda-eve…

841dce1

…nts-notifications

Merge branch 'main' into feature/s3-lambda-events-notifications

30d5dce

GavinZZ previously approved these changes Jun 26, 2024

View reviewed changes

Merge branch 'main' into feature/s3-lambda-events-notifications

e85abcc

sarangarav requested a review from GavinZZ June 26, 2024 19:06

GavinZZ previously approved these changes Jun 26, 2024

View reviewed changes

aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jun 26, 2024

Merge branch 'main' into feature/s3-lambda-events-notifications

b586a30

GavinZZ approved these changes Jun 26, 2024

View reviewed changes

mergify bot merged commit b880067 into aws:main Jun 26, 2024

GavinZZ mentioned this pull request Jun 27, 2024

revert: fix(s3-notifications): unable to delete the existing S3 event notifications (under feature flag) #30699

Merged

mergify bot pushed a commit that referenced this pull request Jun 27, 2024

revert: fix(s3-notifications): unable to delete the existing S3 event…

2869aaa

… notifications (under feature flag) (#30699) Reverts #30610 due to Feature flags issues

github-actions bot mentioned this pull request Jul 1, 2024

Monthly PR metrics report #30715

Closed

aws locked as resolved and limited conversation to collaborators Jul 25, 2024

Conversation

sarangarav commented Jun 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue # (if applicable)

Reason for this change

Description of changes

Description of how you validated changes

Checklist

Uh oh!

aws-cdk-automation left a comment

Choose a reason for hiding this comment

Uh oh!

sarangarav Jun 24, 2024

Choose a reason for hiding this comment

Uh oh!

GavinZZ left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

GavinZZ commented Jun 25, 2024

Uh oh!

mergify bot commented Jun 25, 2024

☑️ Nothing to do

Uh oh!

sarangarav commented Jun 26, 2024

Uh oh!

mergify bot commented Jun 26, 2024

☑️ Nothing to do

Uh oh!

mergify bot commented Jun 26, 2024

Uh oh!

mergify bot commented Jun 26, 2024

Uh oh!

mergify bot commented Jun 26, 2024

Uh oh!

sarangarav commented Jun 26, 2024

Uh oh!

mergify bot commented Jun 26, 2024

✅ Pull request refreshed

Uh oh!

aws-cdk-automation commented Jun 26, 2024

AWS CodeBuild CI Report

Uh oh!

mergify bot commented Jun 26, 2024

Uh oh!

aws-cdk-automation commented Jul 25, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sarangarav commented Jun 21, 2024 •

edited

Loading

GavinZZ left a comment •

edited

Loading