fix(s3): allow import S3 bucket with a legacy name#30679
fix(s3): allow import S3 bucket with a legacy name#30679mergify[bot] merged 5 commits intoaws:mainfrom
Conversation
github-actions
bot
added
bug
aws-cdk-automation
left a comment
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
moelasmar
changed the title
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aws-cdk-automation
added
the
pr/needs-maintainer-review
| const legacyBucketFromName = s3.Bucket.fromBucketName(stack, 'LegacyBucketFromName', 'my_legacy_bucket1'); | ||
|
|
||
| const legacyBucketFromArn = s3.Bucket.fromBucketArn(stack, 'LegacyBucketFromArn', 'arn:aws:s3:::my_legacy_bucket2'); | ||
|
|
||
| const legacyBucketFromAttributes = s3.Bucket.fromBucketAttributes(stack, 'LegacyBucketFromAttributes', { | ||
| bucketName: 'my_legacy_bucket3', | ||
| }); |
There was a problem hiding this comment.
Was this integ test successfully ran? I'm worried that if we need to update the test and re-deploy, it would fail to deploy due to bucket not found.
There was a problem hiding this comment.
It got deployed, but did not really check if it can work or not. Any way let me double check it.
GavinZZ
left a comment
GavinZZ
left a comment
There was a problem hiding this comment.
LGTM, feel free to remove the do-not-merge label once you verified the integ test is working and deployable.
aws-cdk-automation
removed
the
pr/needs-maintainer-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one. |
3 participants
Issue # (if applicable)
Closes #22640.
Reason for this change
Customers could not imported S3 bucket that has a legacy name (contains underscore in the name) and use it in CDK Apps.
Description of changes
This change allowed customer to use S3 buckets legacy names for only the imported S3 buckets, but not for the new ones.
Description of how you validated changes
Added unit test cases, and integration test cases.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license