feat(msk): support Express brokers by mazyu36 · Pull Request #34741 · aws/aws-cdk

mazyu36 · 2025-06-17T14:11:27Z

Issue # (if applicable)

Closes #32923.

Reason for this change

To support express brokers.

Description of changes

Add express property and validations about express limitations.

Describe any new or updated permissions being added

N/A

Description of how you validated changes

Add unit tests and an integ test.

Checklist

My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

aws-cdk-automation

(This review is outdated)

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

aws-cdk-automation · 2025-08-04T16:50:49Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: dea8360
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

badmintoncryer

Thank you for your contribution!

I thought it might be a good idea to add a validation to ensure that the Kafka version is 3.6 or higher, but it also feels a bit excessive.
I’d appreciate it if you could discuss with the maintainer.

badmintoncryer · 2025-09-20T04:59:16Z

@mazyu36 Cloud you please update PR title? It results updating PR labels.

kumsmrit

Thank you for your contribution. I have added some review comments.

kumsmrit · 2025-10-23T13:58:04Z

packages/@aws-cdk/aws-msk-alpha/lib/cluster.ts

+   *
+   * @default false
+   */
+  readonly express?: boolean;


Can we switch from using boolean to enum instead readonly brokerType?: BrokerType; keeping it more future proof ?

enum BrokerType { STANDARD = 'STANDARD', EXPRESS = 'EXPRESS' }

Thanks.
Added Enum.

kumsmrit · 2025-10-23T14:09:38Z

packages/@aws-cdk/aws-msk-alpha/lib/cluster.ts

      throw new core.ValidationError('EBS volume size should be in the range 1-16384', this);
    }

+    if (props.express) {


MSK ExpressBroker is supported only on Apache Kafka 3.6 and 3.8; Can we add that validation please.

Added a validation.

kumsmrit · 2025-10-23T14:35:00Z

packages/@aws-cdk/aws-msk-alpha/README.md

+You can create an MSK cluster with Express Brokers by setting the `express` property to `true`. Express Brokers are a low-cost option for development, testing, and workloads that don't require the high availability guarantees of standard MSK cluster.
+For more information, see [Amazon MSK Express Brokers](https://docs.aws.amazon.com/msk/latest/developerguide/msk-broker-types-express.html).
+
+**Note:** When using Express Brokers, the following constraints apply:


nit: It would also be good to include information about the supported broker sizes

Added.
https://github.com/aws/aws-cdk/pull/34741/files#diff-4406b784e4e36caa633087e16dac06881e3c0c2f3443fbb0770bd3bd37fc3aa9R248

kumsmrit

Thank you for addressing the comments.

mergify · 2025-10-24T16:07:02Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2025-10-24T16:11:24Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2025-10-24T16:40:29Z

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

mazyu36 · 2025-10-24T22:49:37Z

@Mergifyio update

mergify · 2025-10-24T22:49:50Z

update

☑️ Nothing to do, the required conditions are not met

Details

#commits-behind > 0 [📌 update requirement]
-closed [📌 update requirement]
-conflict [📌 update requirement]
queue-position = -1 [📌 update requirement]

Pull request has been modified.

mergify · 2025-10-27T12:13:29Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

github-actions · 2025-10-27T12:13:49Z

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

feat(msk): support Express Brokers

25b01ca

github-actions bot added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 labels Jun 17, 2025

aws-cdk-automation requested a review from a team June 17, 2025 14:11

github-actions bot added the distinguished-contributor [Pilot] contributed 50+ PRs to the CDK label Jun 17, 2025

aws-cdk-automation previously requested changes Jun 17, 2025

View reviewed changes

mazyu36 added 5 commits June 18, 2025 00:16

wip

f95c010

update readme

3851f70

wip

ae768c8

wip

e01e65b

add validation and snapshot test

1a958b8

fix

2cc0f9c

mazyu36 marked this pull request as ready for review June 20, 2025 01:27

mazyu36 added 5 commits June 20, 2025 11:57

Merge branch 'main' into feat/msk-express

c2c11a1

Merge branch 'main' into feat/msk-express

dcea70d

Update integ.cluster-express.ts

2048b76

Update README.md

ab1180c

Merge branch 'main' into feat/msk-express

13272d5

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 23, 2025

github-actions bot mentioned this pull request Jul 1, 2025

Monthly PR metrics report #34865

Closed

Merge branch 'main' into feat/msk-express

dea8360

Merge branch 'main' into feat/msk-express

f2dc968

badmintoncryer approved these changes Sep 9, 2025

View reviewed changes

mazyu36 added 2 commits September 10, 2025 14:50

fix integ

3d2d3a6

Merge branch 'main' into feat/msk-express

88f278a

mazyu36 changed the title ~~feat(msk): support Express Brokers~~ feat(msk): support Express brokers Sep 20, 2025

aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Sep 20, 2025

mazyu36 added 4 commits September 20, 2025 14:34

Merge branch 'main' into feat/msk-express

212ed71

Merge branch 'main' into feat/msk-express

70e0382

Merge branch 'main' into feat/msk-express

63e0669

Merge branch 'main' into feat/msk-express

a63d8cf

mazyu36 had a problem deploying to deployment-integ-test October 7, 2025 12:54 — with GitHub Actions Error

kumsmrit self-assigned this Oct 8, 2025

kumsmrit reviewed Oct 23, 2025

View reviewed changes

mazyu36 added 3 commits October 24, 2025 12:50

comments

fe2e105

Merge branch 'main' into feat/msk-express

4564190

update

9ee8d63

mazyu36 requested a review from kumsmrit October 24, 2025 11:26

kumsmrit previously approved these changes Oct 24, 2025

View reviewed changes

aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 24, 2025

Merge branch 'main' into feat/msk-express

1ce4075

Merge branch 'main' into feat/msk-express

be5a1f9

kumsmrit approved these changes Oct 27, 2025

View reviewed changes

mergify bot merged commit 0a69e5f into aws:main Oct 27, 2025
21 of 22 checks passed

github-actions bot locked as resolved and limited conversation to collaborators Oct 27, 2025

Conversation

mazyu36 commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue # (if applicable)

Reason for this change

Description of changes

Describe any new or updated permissions being added

Description of how you validated changes

Checklist

Uh oh!

aws-cdk-automation left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aws-cdk-automation commented Aug 4, 2025

AWS CodeBuild CI Report

Uh oh!

badmintoncryer left a comment

Choose a reason for hiding this comment

Uh oh!

badmintoncryer commented Sep 20, 2025

Uh oh!

kumsmrit left a comment

Choose a reason for hiding this comment

Uh oh!

kumsmrit Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

mazyu36 Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

kumsmrit Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

mazyu36 Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

kumsmrit Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

mazyu36 Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

kumsmrit left a comment

Choose a reason for hiding this comment

Uh oh!

mergify bot commented Oct 24, 2025

Uh oh!

mergify bot commented Oct 24, 2025

Uh oh!

mergify bot commented Oct 24, 2025

The merge conditions cannot be satisfied due to failing checks:

Uh oh!

mazyu36 commented Oct 24, 2025

Uh oh!

mergify bot commented Oct 24, 2025

☑️ Nothing to do, the required conditions are not met

Uh oh!

mergify bot commented Oct 27, 2025

Uh oh!

Uh oh!

github-actions bot commented Oct 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mazyu36 commented Jun 17, 2025 •

edited

Loading

aws-cdk-automation left a comment •

edited

Loading