fix(pipelines): propagate CodeBuild fleet and certificate#35673
fix(pipelines): propagate CodeBuild fleet and certificate#35673mergify[bot] merged 3 commits intoaws:mainfrom
fleet and certificate#35673Conversation
302ec79 to
f8a832b
Compare
|
@isker Can you merge from main and resolve the conflicts ? |
|
I will do that, but is it going to then sit for another two months without a review? Contributing to this project is pretty demoralizing in this regard. |
These properties were simply overlooked. I added a TypeScript `satisfies` assertion to ensure that newly added properties are not missed here.
f8a832b to
260cc05
Compare
|
||||||||||||||||||||
|
||||||||||||||||||||
leonmk-aws
left a comment
There was a problem hiding this comment.
Thank you for your merging from main (without this I cannot merge the PR), for your patience and for the longterm fix to prevent this from happening in the future !
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Merge Queue Status🚫 The pull request has left the queue (rule: This pull request spent 4 seconds in the queue, with no time running CI. ReasonThe pull request can't be updated
HintYou should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again. |
Pull request has been modified.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Merge Queue Status✅ The pull request has been merged at fc0e79b This pull request spent 35 minutes 20 seconds in the queue, including 35 minutes 11 seconds running CI. Required conditions to merge
|
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #35664.
Reason for this change
You can't use Fleets or certificates currently in CDK pipelines.
Description of changes
These properties were simply overlooked. I added a TypeScript
satisfiesassertion to ensure that newly added properties are not missed here.Describe any new or updated permissions being added
N/A
Description of how you validated changes
Unit and integration tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license