Skip to content

fix(pipelines): propagate CodeBuild fleet and certificate#35673

Merged
mergify[bot] merged 3 commits intoaws:mainfrom
isker:pipelines-fleet-certificate
Dec 9, 2025
Merged

fix(pipelines): propagate CodeBuild fleet and certificate#35673
mergify[bot] merged 3 commits intoaws:mainfrom
isker:pipelines-fleet-certificate

Conversation

@isker
Copy link
Copy Markdown
Contributor

@isker isker commented Oct 3, 2025

Issue # (if applicable)

Closes #35664.

Reason for this change

You can't use Fleets or certificates currently in CDK pipelines.

Description of changes

These properties were simply overlooked. I added a TypeScript satisfies assertion to ensure that newly added properties are not missed here.

Describe any new or updated permissions being added

N/A

Description of how you validated changes

Unit and integration tests.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added bug This issue is a bug. p2 valued-contributor [Pilot] contributed between 6-12 PRs to the CDK labels Oct 3, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team October 3, 2025 16:20
@isker isker force-pushed the pipelines-fleet-certificate branch from 302ec79 to f8a832b Compare October 3, 2025 20:24
@github-actions github-actions bot added the effort/medium Medium work item – several days of effort label Oct 3, 2025
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 3, 2025
@leonmk-aws leonmk-aws self-assigned this Dec 3, 2025
@leonmk-aws
Copy link
Copy Markdown
Contributor

@isker Can you merge from main and resolve the conflicts ?

@isker
Copy link
Copy Markdown
Contributor Author

isker commented Dec 5, 2025

I will do that, but is it going to then sit for another two months without a review? Contributing to this project is pretty demoralizing in this regard.

These properties were simply overlooked. I added a TypeScript
`satisfies` assertion to ensure that newly added properties are not
missed here.
@isker isker force-pushed the pipelines-fleet-certificate branch from f8a832b to 260cc05 Compare December 5, 2025 19:06
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 5, 2025

TestsPassed ☑️SkippedFailed ❌️
Security Guardian Results26 ran24 passed2 failed
TestResult
Security Guardian Results
packages/@aws-cdk-testing/framework-integ/test/pipelines/test/integ.pipeline-with-variables.js.snapshot/VariablePipelineStack.template.json
iam-no-wildcard-actions-inline.guard❌ failure
s3-encryption-enabled.guard❌ failure

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 5, 2025

TestsPassed ☑️SkippedFailed ❌️
Security Guardian Results with resolved templates26 ran24 passed2 failed
TestResult
Security Guardian Results with resolved templates
packages/@aws-cdk-testing/framework-integ/test/pipelines/test/integ.pipeline-with-variables.js.snapshot/VariablePipelineStack.template.json
iam-no-wildcard-actions-inline.guard❌ failure
s3-encryption-enabled.guard❌ failure

@leonmk-aws leonmk-aws added the pr/needs-integration-tests-deployment Requires the PR to deploy the integration test snapshots. label Dec 8, 2025
@leonmk-aws leonmk-aws had a problem deploying to deployment-integ-test December 8, 2025 13:17 — with GitHub Actions Failure
leonmk-aws
leonmk-aws previously approved these changes Dec 8, 2025
Copy link
Copy Markdown
Contributor

@leonmk-aws leonmk-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your merging from main (without this I cannot merge the PR), for your patience and for the longterm fix to prevent this from happening in the future !

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Dec 8, 2025
@leonmk-aws leonmk-aws removed the pr/needs-integration-tests-deployment Requires the PR to deploy the integration test snapshots. label Dec 8, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 8, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 8, 2025

Merge Queue Status

🚫 The pull request has left the queue (rule: default-squash) at 260cc05

This pull request spent 4 seconds in the queue, with no time running CI.

Reason

The pull request can't be updated

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/security-guardian.yml without workflows permission

Hint

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@mergify mergify bot dismissed leonmk-aws’s stale review December 9, 2025 12:43

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Dec 9, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 9, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 9, 2025

Merge Queue Status

✅ The pull request has been merged at fc0e79b

This pull request spent 35 minutes 20 seconds in the queue, including 35 minutes 11 seconds running CI.
The checks were run in-place.

Required conditions to merge

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 9, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 71cfd60 into aws:main Dec 9, 2025
19 of 23 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 9, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 9, 2025
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Dec 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug This issue is a bug. effort/medium Medium work item – several days of effort p2 valued-contributor [Pilot] contributed between 6-12 PRs to the CDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pipelines: fleet property dropped when merging CodeBuildOptions

3 participants