Skip to content

fix: compilation failure in Go#35871

Merged
mergify[bot] merged 5 commits intomainfrom
revert-35770-huijbers/real-intersection
Oct 28, 2025
Merged

fix: compilation failure in Go#35871
mergify[bot] merged 5 commits intomainfrom
revert-35770-huijbers/real-intersection

Conversation

@rix0rrr
Copy link
Copy Markdown
Contributor

@rix0rrr rix0rrr commented Oct 28, 2025

This is a revert of #35770; jsii-pacmak doesn't generate correct Go code for cross-module type intersections.

Fixes #35862.

@rix0rrr rix0rrr requested review from a team October 28, 2025 08:54
@github-actions github-actions bot added bug This issue is a bug. p1 labels Oct 28, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team October 28, 2025 08:54
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 28, 2025
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@rix0rrr rix0rrr added pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Oct 28, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review October 28, 2025 09:03

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 28, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 28, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 5e4f603 into main Oct 28, 2025
18 of 19 checks passed
@mergify mergify bot deleted the revert-35770-huijbers/real-intersection branch October 28, 2025 16:53
@github-actions
Copy link
Copy Markdown
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug This issue is a bug. contribution/core This is a PR that came from AWS. p1 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

aws-cdk-go@v2.221.0: deploy not working due to undefined value

3 participants