Skip to content

fix(elasticache-alpha): the default engine for NoPasswordUser contradict in the docs#35920

Merged
mergify[bot] merged 4 commits intoaws:mainfrom
mazyu36:fix-elasticache
Dec 12, 2025
Merged

fix(elasticache-alpha): the default engine for NoPasswordUser contradict in the docs#35920
mergify[bot] merged 4 commits intoaws:mainfrom
mazyu36:fix-elasticache

Conversation

@mazyu36
Copy link
Copy Markdown
Contributor

@mazyu36 mazyu36 commented Nov 1, 2025

Issue # (if applicable)

Closes #35847

Reason for this change

NoPasswordUser only supports the Redis engine, but the documentation incorrectly states that the default engine is VALKEY, creating a contradiction between the implementation and documentation. Since NoPasswordUser only works with Redis, the engine property should not be configurable for this user type.

Description of changes

  • Fixed the contradiction by removing the engine configuration option from NoPasswordUser.
  • The engine property was moved from the base user class to only the user types that actually support multiple engines (IamUserProps and PasswordUserProps).

Describe any new or updated permissions being added

No new or updated IAM permissions are being added with these changes.

Description of how you validated changes

  • Verified that all existing unit tests pass after the changes
  • Updated test cases to remove references to the now-removed engine property in NoPasswordUser tests

Checklist

BREAKING CHANGE: The engine property in NoPasswordUserProps has been removed.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team November 1, 2025 15:16
@github-actions github-actions bot added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 distinguished-contributor [Pilot] contributed 50+ PRs to the CDK labels Nov 1, 2025
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@mazyu36 mazyu36 changed the title fix(elasticache): the default engine for NoPasswordUser contradict in the docs fix(elasticache): the default engine for NoPasswordUser contradict in the docs Nov 2, 2025
@mazyu36
Copy link
Copy Markdown
Contributor Author

mazyu36 commented Nov 2, 2025

Exemption request: Only changes to the setting method of the property, sufficient with unit tests.

@aws-cdk-automation aws-cdk-automation added pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Nov 2, 2025
@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Nov 19, 2025
@ozelalisen ozelalisen self-assigned this Dec 11, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 12, 2025

TestsPassed ❌️SkippedFailed
Security Guardian Results
TestResult
No test annotations available

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 12, 2025

TestsPassed ❌️SkippedFailed
Security Guardian Results with resolved templates
TestResult
No test annotations available

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 12, 2025
@ozelalisen ozelalisen changed the title fix(elasticache): the default engine for NoPasswordUser contradict in the docs fix(elasticache-alpha): the default engine for NoPasswordUser contradict in the docs Dec 12, 2025
@ozelalisen ozelalisen added pr-linter/exempt-integ-test The PR linter will not require integ test changes and removed pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. labels Dec 12, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review December 12, 2025 13:24

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 12, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 495fa37 into aws:main Dec 12, 2025
24 of 25 checks passed
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 12, 2025

Merge Queue Status

✅ The pull request has been merged at bc466a0

This pull request spent 6 seconds in the queue, with no time running CI.
The checks were run in-place.

Required conditions to merge

@github-actions
Copy link
Copy Markdown
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

distinguished-contributor [Pilot] contributed 50+ PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

elasticache: the default engine for NoPasswordUser contradict in the docs

4 participants