feat(imagebuilder-alpha): add support for Component Construct#36006
feat(imagebuilder-alpha): add support for Component Construct#36006mergify[bot] merged 8 commits intoaws:mainfrom
Conversation
2b1ee8a to
b9d17a0
Compare
ozelalisen
left a comment
There was a problem hiding this comment.
Left some comments as first part of the review, I am not fully completed
ozelalisen
left a comment
There was a problem hiding this comment.
Publishing second round of comments
packages/@aws-cdk/aws-imagebuilder-alpha/test/integ.all-parameters.component.ts
Outdated
Show resolved
Hide resolved
|
Just reminder for next PRs that title should include alpha suffix to be appeared in the CHANGELOG correctly |
b9d17a0 to
5667d1a
Compare
Pull request has been modified.
Pull request has been modified.
33fb075 to
0d7a7d4
Compare
c913c97 to
ac32fa8
Compare
19c626e to
ae6e5fe
Compare
ae6e5fe to
543dea7
Compare
eaabce9 to
ee7672a
Compare
ozelalisen
left a comment
There was a problem hiding this comment.
Thank you for addressing all comments, I have last two comments, rest is looking good.
Pull request has been modified.
ozelalisen
left a comment
There was a problem hiding this comment.
Thank you again for addressing all comments, ready to merge now
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue
aws/aws-cdk-rfcs#789
Reason for this change
This change adds a new alpha module for EC2 Image Builder L2 Constructs (
@aws-cdk/aws-imagebuilder-alpha), as outlined in aws/aws-cdk-rfcs#789. This PR specifically implements theComponentconstruct.Description of changes
This change implements the
Componentconstruct, which is a higher-level construct ofCfnComponent.Example
Describe any new or updated permissions being added
N/A - new L2 construct in alpha module
Description of how you validated changes
Validated with unit tests and integration tests. Manually verified generated CFN templates as well.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license