feat(events-targets): support messageGroupId for standard SQS queues by ravilg-aws · Pull Request #36068 · aws/aws-cdk

ravilg-aws · 2025-11-14T18:15:54Z

Description

EventBridge now supports the messageGroupId parameter for standard (non-FIFO) SQS targets. This PR removes the client-side validation that was preventing customers from using this feature.

Changes

Removed validation error in SqsQueue constructor that blocked messageGroupId for standard queues
Updated JSDoc to clarify that messageGroupId is now supported for both FIFO and standard queues
Updated test from expecting an error to verifying proper CloudFormation synthesis

Background

The EventBridge service API has always supported messageGroupId as an optional parameter for SqsParameters, but the service validation previously rejected it for standard queues. With the recent backend service change (CR-231214910), EventBridge now accepts messageGroupId for standard SQS queues, enabling customers to use this parameter for message grouping.

Testing

Unit tests updated to verify messageGroupId works with standard queues
Existing FIFO queue tests continue to work
All existing SQS target tests pass

Checklist

My code adheres to the CONTRIBUTING GUIDE
Updated tests
Updated documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

EventBridge now supports the messageGroupId parameter for standard (non-FIFO) SQS targets. This change removes the client-side validation that was blocking this feature. Fixes: Removes ValidationError when messageGroupId is used with standard queues Tests: Updated test to verify messageGroupId works with standard queues Docs: Updated JSDoc to reflect support for both queue types

aws-cdk-automation

(This review is outdated)

…sageGroupId - Added comprehensive README documentation showing messageGroupId usage for both FIFO and standard queues - Updated integration test to include messageGroupId example with standard queue - Addresses PR feedback requiring README and integration test changes

Added CloudFormation resources for standard queue with messageGroupId: - StandardQueue resource - StandardQueuePolicy with EventBridge permissions - StandardQueueRule with SqsParameters.MessageGroupId

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

ravilg-aws · 2025-11-15T19:01:22Z

The integration test "destructive changes" are intentional and expected. I've added three new resources to the integration test to demonstrate the messageGroupId feature with standard (non-FIFO) SQS queues:

StandardQueue4A8B3C4D: A standard SQS queue
StandardQueuePolicyFB772D09: Queue policy granting EventBridge permissions
StandardQueueRule2E5F2E91: EventBridge rule configured with SqsParameters.MessageGroupId

These resources are necessary to validate that messageGroupId now works correctly with standard queues, which is the core functionality being added in this PR. The existing test only covered FIFO queues and encrypted queues with dead letter queues - this addition provides coverage for the new standard queue capability.

fjelliott

LGTM! Wondering when this'll get merged.

aemada-aws · 2025-12-01T22:21:11Z

@Mergifyio update

mergify · 2025-12-01T22:21:20Z

update

❌ Mergify doesn't have permission to update

Details

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/analytics-metadata-updater.yml without workflows permission

…tandard-queues

Pull request has been modified.

- Added StandardQueue resource structure - Added StandardQueueRule resource structure with sqsParameters containing messageGroupId

…ues' of https://github.com/ravilg-aws/aws-cdk into feat/events-targets-support-messagegroupid-standard-queues

Pull request has been modified.

The integration test now explicitly allows destruction of the new standard queue resources: - StandardQueue4A8B3C4D - StandardQueuePolicyFB772D09 - StandardQueueRule2E5F2E91 These resources were added to demonstrate messageGroupId support for standard queues.

…tandard-queues

Updated integration test snapshots to allow destructive changes for StandardQueue resources: - Added StandardQueue, StandardQueuePolicy, and StandardQueueRule logical IDs to allowDestroy list in integ.json - Added missing metadata entries for StandardQueue resources in manifest.json This fixes the build failure where the integ-runner was flagging these resources as destructive changes.

Add trace metadata indicating destructive changes for StandardQueue resources: - StandardQueue4A8B3C4D - StandardQueuePolicyFB772D09 - StandardQueueRule2E5F2E91 This marks these resources with WILL_DESTROY traces in the manifest to document the destructive nature of the changes.

…in manifest.json

…h resource types

…tandard-queues

github-actions · 2025-12-06T21:11:56Z

	Tests	Passed ✅	Skipped	Failed
Security Guardian Results	26 ran	26 passed

Test	Result
No test annotations available

View Security Guardian Results

github-actions · 2025-12-06T21:11:58Z

	Tests	Passed ✅	Skipped	Failed
Security Guardian Results with resolved templates	26 ran	26 passed

Test	Result
No test annotations available

View Security Guardian Results with resolved templates

aws-cdk-automation · 2025-12-07T00:15:05Z

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. Note that PRs with failing linting check or builds are not reviewed, please ensure your build is passing

To prevent automatic closure:

Resume work on the PR
OR request an exemption by adding a comment containing 'Exemption Request' with justification e.x "Exemption Request: "
OR request clarification by adding a comment containing 'Clarification Request' with a question e.x "Clarification Request: "

This PR will automatically close in 14 days if no action is taken.

…t code block (line 728). Both code blocks now rely on the fixture's import, so there's no duplicate.

…tandard-queues

pahud · 2025-12-10T14:23:28Z

Interesting, the PR linter validation considered it maintainerApproved because of this and removed the needs review label. I think this PR is all set.

evaluation:  {
  "draft": false,
  "mergeable_state": "behind",
  "maintainerRequestedChanges": false,
  "maintainerApproved": true,
  "communityRequestedChanges": false,
  "communityApproved": false,
  "userRequestsExemption": false
}
{
  addLabels: undefined,
  removeLabels: [ 'pr/needs-community-review', 'pr/needs-maintainer-review' ],
  requestChanges: undefined,
  deleteComments: undefined,
  dismissPreviousReview: true
}
Carrying out actions

…tandard-queues

mergify · 2025-12-15T18:33:20Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2025-12-15T18:33:25Z

Merge Queue Status

🚫 The pull request has left the queue (rule: default-squash) at 3e192ff

This pull request spent 5 seconds in the queue, with no time running CI.

Reason

The pull request can't be updated

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/codebuild-pr-build.yml without workflows permission

Hint

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

…tandard-queues

mergify · 2025-12-15T19:05:28Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2025-12-15T19:05:35Z

github-actions · 2025-12-15T19:05:43Z

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

aws-cdk-automation requested a review from a team November 14, 2025 18:16

github-actions bot added p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Nov 14, 2025

aws-cdk-automation previously requested changes Nov 14, 2025

View reviewed changes

pahud mentioned this pull request Nov 14, 2025

CI Pending Approval - 41 PR(s) pahud/aws-cdk#11

Open

ravilg-aws added 3 commits November 14, 2025 13:58

fix: remove unused ValidationError import

1278d09

JSDoc wording update

9a301dd

test: update integration test snapshot for messageGroupId

378ceca

Added CloudFormation resources for standard queue with messageGroupId: - StandardQueue resource - StandardQueuePolicy with EventBridge permissions - StandardQueueRule with SqsParameters.MessageGroupId

This was referenced Nov 15, 2025

Failed CodeBuild CI - 26 PR(s) need attention pahud/aws-cdk#14

Merged

Failed CodeBuild CI - 32 PR(s) pahud/aws-cdk#17

Open

awesomelike approved these changes Nov 15, 2025

View reviewed changes

fjelliott approved these changes Nov 20, 2025

View reviewed changes

github-actions bot mentioned this pull request Dec 1, 2025

Monthly PR metrics report #36251

Open

aemada-aws previously approved these changes Dec 1, 2025

View reviewed changes

Merge branch 'main' into feat/events-targets-support-messagegroupid-s…

b5e9cc2

…tandard-queues

aemada-aws previously approved these changes Dec 1, 2025

View reviewed changes

ravilg-aws added 2 commits December 2, 2025 09:28

Snapshot fix

20de5d0

- Added StandardQueue resource structure - Added StandardQueueRule resource structure with sqsParameters containing messageGroupId

Merge branch 'feat/events-targets-support-messagegroupid-standard-que…

6a9c746

…ues' of https://github.com/ravilg-aws/aws-cdk into feat/events-targets-support-messagegroupid-standard-queues

ravilg-aws added 4 commits December 2, 2025 10:19

Merge branch 'main' into feat/events-targets-support-messagegroupid-s…

357297f

…tandard-queues

ravilg-aws added 6 commits December 3, 2025 11:48

Added will destroy to manifest.json as well

621783b

Removed allowDestory, following other examples, keeping will_destory …

7644acc

…in manifest.json

Replaced app.synth() with IntegTest construct. Added allowDestroy wit…

c7d2461

…h resource types

Set the correct hash for assertionStackName

8951423

fix: add diffAssets and stackUpdateWorkflow to integ test snapshot

11cb540

Merge branch 'main' into feat/events-targets-support-messagegroupid-s…

93e6630

…tandard-queues

ravilg-aws added 7 commits December 7, 2025 05:53

adressing security guardian comments

18e77ca

security guardian fix 2

87fee9a

snapshot update

af50ffd

logical ids udpate

e7f68ac

Readme fix for rosetta build

9f6c3f4

Removed the import * as sqs from 'aws-cdk-lib/aws-sqs'; from the firs…

57f73ae

…t code block (line 728). Both code blocks now rely on the fixture's import, so there's no duplicate.

Merge branch 'main' into feat/events-targets-support-messagegroupid-s…

2d2187e

…tandard-queues

fjelliott approved these changes Dec 10, 2025

View reviewed changes

ravilg-aws added 2 commits December 10, 2025 19:55

Merge branch 'main' into feat/events-targets-support-messagegroupid-s…

5e98b36

…tandard-queues

Merge branch 'main' into feat/events-targets-support-messagegroupid-s…

3e192ff

…tandard-queues

aemada-aws approved these changes Dec 15, 2025

View reviewed changes

Merge branch 'main' into feat/events-targets-support-messagegroupid-s…

90475ff

…tandard-queues

aemada-aws approved these changes Dec 15, 2025

View reviewed changes

mergify bot merged commit 95d4ed5 into aws:main Dec 15, 2025
22 of 23 checks passed

github-actions bot locked as resolved and limited conversation to collaborators Dec 15, 2025

Conversation

ravilg-aws commented Nov 14, 2025

Description

Changes

Background

Testing

Checklist

Uh oh!

aws-cdk-automation left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ravilg-aws commented Nov 15, 2025

Uh oh!

fjelliott left a comment

Choose a reason for hiding this comment

Uh oh!

aemada-aws commented Dec 1, 2025

Uh oh!

mergify bot commented Dec 1, 2025

❌ Mergify doesn't have permission to update

Uh oh!

github-actions bot commented Dec 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aws-cdk-automation commented Dec 7, 2025

Uh oh!

pahud commented Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mergify bot commented Dec 15, 2025

Uh oh!

mergify bot commented Dec 15, 2025

Merge Queue Status

Reason

Hint

Uh oh!

mergify bot commented Dec 15, 2025

Uh oh!

Uh oh!

mergify bot commented Dec 15, 2025

Merge Queue Status

Uh oh!

github-actions bot commented Dec 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

aws-cdk-automation left a comment •

edited

Loading

github-actions bot commented Dec 6, 2025 •

edited

Loading

github-actions bot commented Dec 6, 2025 •

edited

Loading

pahud commented Dec 10, 2025 •

edited

Loading