feat(dynamodb): add TableGrants and StreamGrants#36093
Merged
mergify[bot] merged 8 commits intomainfrom Nov 19, 2025
Merged
Conversation
aws-cdk-automation
previously requested changes
Nov 18, 2025
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
rix0rrr
approved these changes
Nov 18, 2025
rix0rrr
approved these changes
Nov 18, 2025
Contributor
rix0rrr
left a comment
There was a problem hiding this comment.
Approved but we said we would do consturctor parameters over the interface implementation
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changing?
This PR introduces two new classes,
TableGrantsandStreamGrants, that allow the assignment of permissions, in a uniform way, to both L1s and L2s:To make the interface more similar to the auto-generated grants (e.g.,
TopicGrants),TableGrants._fromTable()takes a new interface,IIndexableRegionalTableas a parameter.And now
TableBaseimplementsIIndexableRegionalTable.TableBasehas also gained two additional public immutable properties:grantsandstreamGrants, that should be used to grant permissions on a table. The existinggrant*()methods will be deprecated soon.Why did the integration test templates change?
The current implementation uses
Lazy.string()to produce the regional ARNs. Since theproduce()method has to return something, it returnedAws.NO_VALUEwhen there was no real value to produce. InTableGrants, by contrast, the ARNs are computed eagerly in the constructor, so there is no need for pseudo-values. This is what caused the integration test templates to change. There are additional changes that are purely in the order of JSON properties.Why does
StreamGrantsnot have a_fromStream()static method?Unlike table, a table stream is not a resource in CloudFormation. So, although we could try to mimic one, by creating interfaces like
ITableStream,ITableStreamRef,TableStreamReference, there is nothing to gain from it. The consumer would still have to assemble an object from properties of aTableofCfnTableanyway.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license