feat(events): the L2 EventPattern interfaces can be used with CfnRule#36191
Merged
mergify[bot] merged 3 commits intomainfrom Nov 25, 2025
Merged
feat(events): the L2 EventPattern interfaces can be used with CfnRule#36191mergify[bot] merged 3 commits intomainfrom
EventPattern interfaces can be used with CfnRule#36191mergify[bot] merged 3 commits intomainfrom
Conversation
It is now possible to use the L2 `EventPattern` interface to synthesize
events that will work with the L1 `CfnRule` class:
```ts
// L1
interface CfnRuleProps {
readonly eventPattern: any; // <-- not typed
}
// L2
interface RuleProps {
readonly eventPattern: EventPattern; // <-- typed
}
```
At the L1, there is "raw data"; the L2 translates the fields of
the `EventPattern` type to the correct fields of "raw data".
In practice, the only difference is that one of the raw data
fields is called `detail-type`, which in the L2 type is called
`detailType`. All other fields are the same.
We add the ability to render specific fields of specific L1s
differently if we so choose: the renderer for `CfnRule` now
has gotten the ability to specifically recognize `detailType`
and translate it to `detail-type`.
This now makes both classes take the same inputs.
aws-cdk-automation
previously requested changes
Nov 25, 2025
mrgrain
changed the title
EventPattern can be used for CfnRuleEventPattern can be used for CfnRule
mrgrain
changed the title
EventPattern can be used for CfnRuleEventPattern interfaces can be used with CfnRule
mrgrain
approved these changes
Nov 25, 2025
rix0rrr
added
pr-linter/exempt-readme
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Contributor
Merge Queue Status
✅ The pull request has been merged This pull request spent 1 hour 43 minutes in the queue, including 30 minutes 10 seconds waiting for CI. Required conditions to merge
|
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objects that conform to the L2
EventPatterninterface are now interpreted correctly by the L1CfnRuleclass:At the L1, there is "raw data"; the L2 translates the fields of the
EventPatterntype to the correct fields of "raw data".In practice, the only difference is that one of the raw data fields is called
detail-type, which in the L2 type is calleddetailType. All other fields are the same.We add the ability to render specific fields of specific L1s differently if we so choose: the renderer for
CfnRulenow has gotten the ability to specifically recognizedetailTypeand translate it todetail-type.This now makes both classes take the same inputs, reducing a common cause of user confusion and mistakes.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license