fix(mixins-preview): service exports are different then in `aws-cdk-lib` by mrgrain · Pull Request #36201 · aws/aws-cdk

mrgrain · 2025-11-25T22:29:02Z

Issue

Reason for this change

@aws-cdk/mixins-preview exports services as aws_s3 (note the underscore).
But aws-cdk-lib exports them as aws-s3 (note the dash).

The intention was to align how the exports are named for ease of future migration. Better to fix this now.

Description of changes

Renaming aws_<SERVICE> to aws-<service> and the required update of cdk-generate-synthetic-examples.

Describe any new or updated permissions being added

n/a

Description of how you validated changes

test pipeline

Checklist

My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

aws-cdk-automation

(This review is outdated)

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

aws-cdk-automation · 2025-11-25T22:52:14Z

➡️ PR build request submitted to test-main-pipeline ⬅️

A maintainer must now check the pipeline and add the pr-linter/cli-integ-tested label once the pipeline succeeds.

rix0rrr

vishaalmehrishi · 2025-12-02T13:31:14Z

packages/@aws-cdk/mixins-preview/scripts/gen.ts


    // @aws-cdk/mixins-preview/aws-s3 => `export * as aws_s3 from './aws-s3';`
    if (!serviceIndexExports.find(e => e.includes(moduleConfig.name))) {
      serviceIndexExports.push(`export * as ${moduleConfig.submodule} from './${moduleConfig.name}';`);


Does this need to change as well?

Suggested change

serviceIndexExports.push(`export * as ${moduleConfig.name} from './${moduleConfig.name}';`);

Not sure why the suggestion formatting was messed up, but here's what I am referring to specifically:

export * as ${moduleConfig.submodule} -> export * as ${moduleConfig.name}

No. These exported symbols are using _ in aws-cdk-lib (also symbols cannot have a - in their name). It's only the export paths that use -.

mrgrain · 2025-12-02T18:27:17Z

@Mergifyio refresh

mergify · 2025-12-02T18:27:29Z

refresh

✅ Pull request refreshed

answered

mergify · 2025-12-02T18:37:13Z

mergify · 2025-12-02T18:37:14Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2025-12-02T19:18:38Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

github-actions · 2025-12-02T19:18:51Z

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

aws-cdk-automation requested a review from a team November 25, 2025 22:29

github-actions bot added the p2 label Nov 25, 2025

mergify bot added the contribution/core This is a PR that came from AWS. label Nov 25, 2025

aws-cdk-automation previously requested changes Nov 25, 2025

View reviewed changes

mrgrain added pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Nov 25, 2025

mrgrain force-pushed the mrgrain/fix/mixins-exports branch from 96abbf7 to d1c42d4 Compare November 25, 2025 22:39

mrgrain added the pr/request-cli-integ-tests Request CLI integ tests to be run. You will need to review the code and approve the deployment. label Nov 25, 2025

mrgrain temporarily deployed to test-pipeline November 25, 2025 22:49 — with GitHub Actions Inactive

mrgrain changed the title ~~fix(mixins-preview): exports are different then in aws-cdk-lib~~ fix(mixins-preview): service exports are different then in aws-cdk-lib Nov 25, 2025

aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 25, 2025

mrgrain marked this pull request as draft November 26, 2025 00:02

rix0rrr reviewed Nov 26, 2025

View reviewed changes

pahud mentioned this pull request Nov 26, 2025

PRs with Conflicts - 13 PR(s) pahud/aws-cdk#13

Open

aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 29, 2025

mrgrain force-pushed the mrgrain/fix/mixins-exports branch 2 times, most recently from c4ba55a to 86844ce Compare November 29, 2025 14:12

mrgrain marked this pull request as ready for review November 29, 2025 15:16

mrgrain added the pr/do-not-merge This PR should not be merged at this time. label Nov 29, 2025

aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 29, 2025

github-actions bot mentioned this pull request Dec 1, 2025

Monthly PR metrics report #36251

Open

rix0rrr approved these changes Dec 1, 2025

View reviewed changes

aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 1, 2025

rix0rrr marked this pull request as draft December 1, 2025 16:11

mrgrain force-pushed the mrgrain/fix/mixins-exports branch from 86844ce to f8e09f3 Compare December 1, 2025 22:26

fix(mixins-preview): exports are different then in aws-cdk-lib

b4b8896

mrgrain force-pushed the mrgrain/fix/mixins-exports branch from f8e09f3 to b4b8896 Compare December 1, 2025 22:33

mrgrain marked this pull request as ready for review December 1, 2025 22:36

vishaalmehrishi previously requested changes Dec 2, 2025

View reviewed changes

mrgrain removed the pr/do-not-merge This PR should not be merged at this time. label Dec 2, 2025

mrgrain had a problem deploying to test-pipeline December 2, 2025 18:28 — with GitHub Actions Failure

mrgrain removed the pr/request-cli-integ-tests Request CLI integ tests to be run. You will need to review the code and approve the deployment. label Dec 2, 2025

Merge branch 'main' into mrgrain/fix/mixins-exports

7ec8a4a

mergify bot merged commit 5858006 into main Dec 2, 2025
19 of 20 checks passed

mergify bot deleted the mrgrain/fix/mixins-exports branch December 2, 2025 19:18

github-actions bot locked as resolved and limited conversation to collaborators Dec 2, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(mixins-preview): service exports are different then in `aws-cdk-lib`#36201

fix(mixins-preview): service exports are different then in `aws-cdk-lib`#36201
mergify[bot] merged 2 commits intomainfrom
mrgrain/fix/mixins-exports

mrgrain commented Nov 25, 2025 •

edited

Loading

Uh oh!

aws-cdk-automation left a comment •

edited

Loading

Uh oh!

aws-cdk-automation commented Nov 25, 2025

Uh oh!

rix0rrr left a comment •

edited

Loading

Uh oh!

vishaalmehrishi Dec 2, 2025

Uh oh!

vishaalmehrishi Dec 2, 2025 •

edited

Loading

Uh oh!

mrgrain Dec 2, 2025

Uh oh!

mrgrain commented Dec 2, 2025

Uh oh!

mergify bot commented Dec 2, 2025

Uh oh!

mergify bot commented Dec 2, 2025 •

edited

Loading

Uh oh!

mergify bot commented Dec 2, 2025

Uh oh!

mergify bot commented Dec 2, 2025

Uh oh!

Uh oh!

github-actions bot commented Dec 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants


	serviceIndexExports.push(`export * as ${moduleConfig.name} from './${moduleConfig.name}';`);

Conversation

mrgrain commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue

Reason for this change

Description of changes

Describe any new or updated permissions being added

Description of how you validated changes

Checklist

Uh oh!

aws-cdk-automation left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aws-cdk-automation commented Nov 25, 2025

Uh oh!

rix0rrr left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vishaalmehrishi Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

vishaalmehrishi Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mrgrain Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

mrgrain commented Dec 2, 2025

Uh oh!

mergify bot commented Dec 2, 2025

✅ Pull request refreshed

Uh oh!

mergify bot commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Queue Status

Uh oh!

mergify bot commented Dec 2, 2025

Uh oh!

mergify bot commented Dec 2, 2025

Uh oh!

Uh oh!

github-actions bot commented Dec 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mrgrain commented Nov 25, 2025 •

edited

Loading

aws-cdk-automation left a comment •

edited

Loading

rix0rrr left a comment •

edited

Loading

vishaalmehrishi Dec 2, 2025 •

edited

Loading

mergify bot commented Dec 2, 2025 •

edited

Loading