Skip to content

revert: turn on stripInternal everywhere#36313

Merged
mergify[bot] merged 2 commits intomainfrom
mehrishi/revert-strip-internal
Dec 5, 2025
Merged

revert: turn on stripInternal everywhere#36313
mergify[bot] merged 2 commits intomainfrom
mehrishi/revert-strip-internal

Conversation

@vishaalmehrishi
Copy link
Copy Markdown
Contributor

@vishaalmehrishi vishaalmehrishi commented Dec 5, 2025

This reverts commit 05b5a2b.

Issue # (if applicable)

Closes #36310

Reason for this change

Stripping out internal types is breaking external-facing types which extend from these internal types. (See the issue).

Description of changes

Clean revert of the original change

Describe any new or updated permissions being added

N/A

Description of how you validated changes

N/A

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team December 5, 2025 18:51
@github-actions github-actions bot added bug This issue is a bug. p0 labels Dec 5, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Dec 5, 2025
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 5, 2025

TestsPassed ❌️SkippedFailed
Security Guardian Results0 ran0 passed0 skipped0 failed
TestResult
No test annotations available

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 5, 2025

TestsPassed ❌️SkippedFailed
Security Guardian Results with resolved templates0 ran0 passed0 skipped0 failed
TestResult
No test annotations available

@vishaalmehrishi vishaalmehrishi changed the title "fix: restoring internal types" revert: turn on stripInternal everywhere Dec 5, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review December 5, 2025 18:56

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 5, 2025

Merge Queue Status

✅ The pull request has been merged

This pull request spent 28 minutes 4 seconds in the queue, including 27 minutes 54 seconds running CI.
The checks were run in-place.

Required conditions to merge

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 5, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 5, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 5869e38 into main Dec 5, 2025
21 of 22 checks passed
@mergify mergify bot deleted the mehrishi/revert-strip-internal branch December 5, 2025 19:47
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 5, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug This issue is a bug. contribution/core This is a PR that came from AWS. p0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(cloudwatch): TypeScript declarations missing for CreateAlarmOptionsBase in v2.232.0

3 participants