fix(aws-cdk-lib): make grants factory methods public#36317
Merged
mergify[bot] merged 1 commit intomainfrom Dec 6, 2025
Merged
Conversation
Make BucketGrants.fromBucket() and StateMachineGrants.fromStateMachine() public APIs by removing @internal markers and underscore prefixes.
ea891a0 to
cbe4491
Compare
Contributor
|
||||||||||||||
Contributor
|
||||||||||||||
rix0rrr
approved these changes
Dec 6, 2025
Contributor
Merge Queue Status✅ The pull request has been merged This pull request spent 5 seconds in the queue, with no time running CI. Required conditions to merge
|
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
N/A
Reason for this change
The grants factory methods
BucketGrants.fromBucket()andStateMachineGrants.fromStateMachine()were marked as internal but are useful for construct authors who want to create custom grant patterns or extend existing grant functionality.Description of changes
@internalJSDoc markers from factory methods_fromBuckettofromBucketand_fromStateMachinetofromStateMachineto follow public API naming conventionsThis change makes it possible for construct authors to create grants objects for custom resources that implement
IBucketReforIStateMachineRef.Describe any new or updated permissions being added
No new or updated IAM permissions are being added. This change only exposes existing grant functionality through a public API.
Description of how you validated changes
Existing unit tests continue to pass with the renamed methods.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license