chore: setup docker images #167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
✅ Heimdall Review Status
|
danyalprout
force-pushed
the
publisher-docker-image
branch
from
e7b712a to
fb5bc94
Compare
danyalprout
force-pushed
the
publisher-docker-image
branch
from
fb5bc94 to
0a76b0f
Compare
meyer9
approved these changes
Nov 4, 2025
Contributor
meyer9
left a comment
meyer9
left a comment
There was a problem hiding this comment.
LG! left a few suggestions, but feel free to take or leave
| on: | ||
| workflow_dispatch: | ||
| inputs: | ||
| ref: |
Contributor
There was a problem hiding this comment.
We may want to use the branch that we already have to pass into the dispatch.
| username: ${{ github.actor }} | ||
| password: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| - name: Generate commit hash tags |
Contributor
There was a problem hiding this comment.
I think we can use docker meta here: https://github.com/docker/metadata-action which will also add opencontainer labels to the built image
| images: ghcr.io/base/node-reth-dev | ||
| tags: | | ||
| type=ref,event=branch | ||
| type=sha,format=short |
Contributor
There was a problem hiding this comment.
would rather just use the full sha so there are no chances of a conflict (very low probability with short shas I know)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ghcr.io/base/node-reth-dev:masteron merges to masterghcr.io/base/node-reth-dev:<commitSha>to the registry