Fix infinite recursion in copy_recursive() #180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not copy files or directories whose names start with `wp-jekyll-*`. This prevents infinite recursion when copying everything under `wp-content/uploads` by excluding Jekyll Exporter's output directory. This also prevents copying the output of previous Jekyll Exporter runs. Without this, my attempts to run Jekyll Exporter end up creating files like the below and eventually timeout. > wp-jekyll-736e13f6e4555fc2ef3ddef3bd223443/wp-content/uploads/wp-jekyll-736e13f6e4555fc2ef3ddef3bd223443/wp-content/uploads/wp-jekyll-736e13f6e4555fc2ef3ddef3bd223443/wp-content/uploads/wp-jekyll-736e13f6e4555fc2ef3ddef3bd223443/wp-content/uploads/2018/07/00036-_DSC2797-enl-300x200.jpg
|
Welcome! Congrats on your first pull request to WordPress To Jekyll Exporter. If you haven't already, please be sure to check out the contributing guidelines. |
|
Congrats on getting your first pull request to WordPress To Jekyll Exporter merged! Without amazing humans like you submitting pull requests, we couldn’t run this project. You rock! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick hack I did to move ahead. I am not sure this is the best way to fix the issue. Also, this seems like such a bad issue that I wonder if there was something wrong with my data that caused it.
Do not copy files or directories whose names start with
wp-jekyll-*. This prevents infinite recursion when copying everything underwp-content/uploadsby excluding Jekyll Exporter's output directory. This also prevents copying the output of previous Jekyll Exporter runs.Without this, my attempts to run Jekyll Exporter end up creating files like the below and eventually timeout.