Skip to content

Commit c5dfba2

Browse files
committed
Improve debug logging
1 parent 714eb93 commit c5dfba2

1 file changed

Lines changed: 13 additions & 5 deletions

File tree

src/petals/server/handler.py

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,7 @@ async def _iterate_inference_steps(
252252
try:
253253
while request.tensors: # iterate while user is willing to supply tensors
254254
metadata = MSGPackSerializer.loads(request.metadata) if request.metadata else {}
255-
logger.info(f"Request: {metadata=}")
255+
self._log_request("rpc_push", requested_uids, context, debug=f"metadata={metadata}")
256256
step_id = metadata.get("step_id")
257257
if step_id is None or step_id not in processed_step_ids:
258258
yield request, metadata
@@ -496,7 +496,13 @@ async def _allocate_cache(
496496
yield nested_pack(handles, descriptors)
497497

498498
def _log_request(
499-
self, method: str, uids: Optional[Sequence[ModuleUID]], context: P2PContext, *, warning: Optional[str] = None
499+
self,
500+
method: str,
501+
uids: Optional[Sequence[ModuleUID]],
502+
context: P2PContext,
503+
*,
504+
debug: Optional[str] = None,
505+
warning: Optional[str] = None,
500506
) -> None:
501507
if uids is not None:
502508
friendly_uids = [uid.split(".")[-1] for uid in uids if "." in uid]
@@ -508,10 +514,12 @@ def _log_request(
508514
friendly_remote_id = "..." + str(context.remote_id)[-6:]
509515

510516
message = f"{method}(blocks={friendly_uids}, remote_peer={friendly_remote_id})"
511-
if warning is None:
512-
logger.info(message)
517+
if warning is not None:
518+
logger.debug(f"{message}: {warning}")
519+
elif debug is not None:
520+
logger.debug(f"{message}: {debug}")
513521
else:
514-
logger.warning(f"{message}: {warning}")
522+
logger.info(message)
515523

516524
async def rpc_info(self, request: runtime_pb2.ExpertUID, context: P2PContext) -> runtime_pb2.ExpertInfo:
517525
"""Return metadata about stored block uids and current load"""

0 commit comments

Comments
 (0)