[PM-24609] Removed deprecated function in CipherMatchingHelper

[fedemkr]

🎟️ Tracking

PM-24609

📔 Objective

Remove deprecated function in CipherMatchingHelper:
func ciphersMatching(uri: String?, ciphers: [CipherListView]) async -> [CipherListView].
Also moved the CipherMatchingHelper tests to the corresponding file now that we don't have that large function tests anymore.
Finally, fixed some warnings on the project.

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[claude]

Claude Code is working…

I'll analyze this and get back to you.

View job run

[github-actions]

Checkmarx One – Scan Summary & Details – f817ac20-892e-48bc-8180-d1d5a0588dcd

Great job! No new security vulnerabilities introduced in this pull request

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.99%. Comparing base (72df545) to head (dc592a9).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2098      +/-   ##
==========================================
- Coverage   85.35%   82.99%   -2.36%     
==========================================
  Files        1699     1969     +270     
  Lines      145612   161120   +15508     
==========================================
+ Hits       124284   133724    +9440     
- Misses      21328    27396    +6068     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.