Skip to content

Conversation

@vvolkgang
Copy link
Member

🎟️ Tracking

PM-28041

📔 Objective

The script used to create SDK Update PRs limited the changelog list to the last 20 PRs. We're removing this limitation now.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@vvolkgang vvolkgang requested review from a team and matt-livefront as code owners November 10, 2025 21:28
@vvolkgang vvolkgang added the t:ci Updates to automated workflows label Nov 10, 2025
@vvolkgang vvolkgang enabled auto-merge (squash) November 10, 2025 21:28
@claude
Copy link

claude bot commented Nov 10, 2025

Claude finished @vvolkgang's task —— View job


Code Review Complete

Tasks:

  • Read the modified shell script file
  • Analyze the change for potential issues
  • Check for related files or tests
  • Provide review feedback

Summary

This PR removes the 20-commit limit from changelog generation in SDK update PRs. The change is straightforward and achieves the stated objective.

Findings

No findings - this is a clean change that accomplishes its purpose without introducing issues.


Change Details

Modified: Scripts/get-repo-changelog.sh:19

  • Removed: | head -20 pipe limiting changelog to 20 entries
  • Impact: SDK update PRs (via .github/workflows/sdlc-sdk-update.yml:213) will now include complete changelog between versions

Considerations validated:

  • No performance concerns (GitHub API handles commit lists efficiently)
  • Output size handled appropriately (changelog wrapped in collapsible <details> section per line 33-39)
  • Script maintains proper error handling for empty changelogs
  • No tests exist for this script (verified via glob/grep searches)

@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details7317ec9c-8810-4b8a-a7a7-c4cd6743e46b

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.77%. Comparing base (ca6c90d) to head (c1820ec).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2125      +/-   ##
==========================================
- Coverage   85.22%   83.77%   -1.45%     
==========================================
  Files        1708     1971     +263     
  Lines      145420   160924   +15504     
==========================================
+ Hits       123940   134822   +10882     
- Misses      21480    26102    +4622     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vvolkgang vvolkgang merged commit c90a01d into main Nov 10, 2025
14 checks passed
@vvolkgang vvolkgang deleted the vvolkgang/changelog branch November 10, 2025 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t:ci Updates to automated workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants