fix(transform): Update Default KV Store TTL offset to 0#151
Merged
Conversation
Documentation states that this is an optional parameter, but the initializing function will return an error if it's not set. > transform: enrich_kv_store_set: time: invalid duration ""
3e0398c to
b78f40b
Compare
jshlbrd
approved these changes
Mar 23, 2024
Contributor
jshlbrd
left a comment
There was a problem hiding this comment.
Good find, there may be other inconsistencies like this between the docs and code. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug in the initializer for the
enrich_kv_store_settransform. Documentation states that this is an optional parameter, but the initializing function will return an error if it's not set.Error received:
Motivation and Context
This resolved a bug where the application was inconsistent with the documentation.
How Has This Been Tested?
Validated that the config from the documentation can be loaded by the application, previously this errored during load.
Types of changes
Checklist: