feat(condition): Add Number Greater Than Inspector#183
Merged
Conversation
6 tasks
6 tasks
Closed
6 tasks
Mallika05
approved these changes
Jun 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
number_greater_thaninspectorMotivation and Context
This is for comparing a number's value, which is currently only possible using the
string_matchfunction like this:sub.cnd.str.match({ object: {source_key: 'FIELD'}, pattern: '^[0-9]{4,}$'}), // 1,000+This inspector is simpler to understand:
sub.cnd.num.greater_than({ object: {source_key: 'FIELD'}, value: 999 }), // 1,000+The target value type is float64, but this works just as well with integers.
Additional functions can be added later (e.g.
equal_to,less_than). This is nested directly under thenumber.*tree to mimic the naming convention of thestring.*functions. This probably needs to be considered along with #64, which could either be a new set of nested functions (e.g.string.compare.equal_to,number.compare.less_than) or be added to existing functions (e.g., ifobject.target_keyexists, then it overridesvalue).How Has This Been Tested?
Added new unit tests.
Types of changes
Checklist: