feat(transform): Add Multi-Transform Support to Meta Transforms#213
Merged
feat(transform): Add Multi-Transform Support to Meta Transforms#213
Conversation
shellcromancer
suggested changes
Jul 24, 2024
Contributor
shellcromancer
left a comment
There was a problem hiding this comment.
Code changes look good, on
shellcromancer
approved these changes
Jul 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Transformsfield to all meta transform functionsTransformfield in all meta transform functionsMotivation and Context
This simplifies the project's use of transform functions by making it so that every meta transform function accepts a list of transform functions (instead of only a single transform function). In v2.0 the existing
transformsupport and the MetaPipeline transform will be removed.For the existing transforms both
transformandtransformsfields have to be supported simultaneously to not introduce a breaking change, like this:Any new meta transform functions should only have a
transformsfield.How Has This Been Tested?
Types of changes
Checklist: