fix(internal/bufio): Default Max Token Size#220
Merged
Conversation
shellcromancer
approved these changes
Jul 29, 2024
Contributor
shellcromancer
left a comment
There was a problem hiding this comment.
Great catch, also confirming that I don't see anywhere else in the codebase we use bitwise XOR for exponentiation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Noticed that this was wrong when working on another PR. These are not equivalent: https://go.dev/play/p/rGQz8_p5zR3. This doesn't affect deployments in AWS Lambda.
How Has This Been Tested?
Try to read a file with very large lines using any file reader app -- it should fail using the main branch but succeed with this change.
Types of changes
Checklist: