Skip to content

fix(build/config): Self-Referential Jsonnet Function#225

Merged
jshlbrd merged 5 commits intomainfrom
jshlbrd/fix/kv-func
Aug 5, 2024
Merged

fix(build/config): Self-Referential Jsonnet Function#225
jshlbrd merged 5 commits intomainfrom
jshlbrd/fix/kv-func

Conversation

@jshlbrd
Copy link
Contributor

@jshlbrd jshlbrd commented Aug 2, 2024

Description

#215 introduced a self-referential function issue. This doesn't impact the source code, but configurations that use this transform can't be compiled and return this Jsonnet error: RUNTIME ERROR: max stack frames exceeded..

Motivation and Context

It's a bug fix.

How Has This Been Tested?

Re-tested the existing example and tested the new examples.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@jshlbrd jshlbrd marked this pull request as ready for review August 2, 2024 23:59
@jshlbrd jshlbrd requested a review from a team as a code owner August 2, 2024 23:59
@jshlbrd jshlbrd merged commit f58665a into main Aug 5, 2024
@jshlbrd jshlbrd deleted the jshlbrd/fix/kv-func branch August 5, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants