Merged
Conversation
julieagnessparks
approved these changes
Sep 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Discovered a bug in the ActiveShards method when handling very large streams -- the Kinesis API does not accept both StreamName and NextToken, it's one or the other and using both causes errors.
Motivation and Context
This was an unknown bug and wasn't discovered until we started seeing anomalous errors with scaling very large streams.
How Has This Been Tested?
Patched in our production AWS accounts, errors seem to be resolved but this is a bit difficult to test because the error only appears at huge scale. If related issues appear then we'll do another fix.
Types of changes
Checklist: