fix(condition): handling of missing source and/or target keys#277
Merged
fix(condition): handling of missing source and/or target keys#277
Conversation
jshlbrd
reviewed
Nov 20, 2024
jshlbrd
reviewed
Nov 21, 2024
condition/number_equal_to_test.go
Outdated
| false, | ||
| }, | ||
| { | ||
| "pass", |
Contributor
There was a problem hiding this comment.
Any tests that return false should be labeled as "fail" ("pass" is for tests that return true).
Contributor
Author
There was a problem hiding this comment.
gotcha, thanks for pointing that out! fixed test cases to reflect expected 'fail' outcomes.
jshlbrd
approved these changes
Nov 22, 2024
Contributor
jshlbrd
left a comment
There was a problem hiding this comment.
There will need to be more work on this prior to the next major update. I think we can do this in more places, but not everywhere without introducing a breaking change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds additional handling of missing source and/or target keys in condition package number equal to and string equal to.
Motivation and Context
Fix for issue:Condition Package Zero Value Matches Can Be Inaccurate #263.
Current behaviour of condition package does not contain source key or target key's object path existence check. This caused unexpected behaviour:
When only src key is present but the path doesn't exist, condition package inaccurately matches on zero value and empty string.
When both source key and target key are present but both paths do not exist, the number equal to and string equal to return true.
This adds checks thus
How Has This Been Tested?
Types of changes
Checklist: