Merged
Conversation
The ForEach JSON processor when used with the default jsonnet helpers pass an empty value for the inner processors input_key, this resulted in inner processor having a selection with a trailing "." such as "processor_type.". This fixes by explicitly handling empty strings when checking the input/output keys.
jshlbrd
approved these changes
Dec 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The ForEach JSON processor when used with the default jsonnet helpers pass an empty value for the inner processors
input_key, this resulted in inner processor having a selection with a trailing.such asprocessor_type.. This fixes the issue by explicitly handling empty strings when checking the input/output keys.Motivation and Context
How Has This Been Tested?
This has been tested with the regression suite, and locally by using configuring a processor via jsonnet as follows and getting the expected result, whereas before this no input would be captured from the input array.
Types of changes
Checklist: