Conversation
julieagnessparks
left a comment
There was a problem hiding this comment.
I like the add of Zeek Intelligence Framework, I was unfamiliar with it but it's a great way to bring in indicators.
Only concern is having documentation for how a user to utilize the test files you added.
| "github.com/brexhq/substation/internal/kv" | ||
| ) | ||
|
|
||
| func Example_memory() { |
There was a problem hiding this comment.
Are there instructions for how someone should use this example test / what should be filled in (TODO)?
There was a problem hiding this comment.
Not really, this is meant as an example for developers and not users who interact through configurations. Once we've merged this the user-facing documentation would be added to substation.readme.io, both as a processor and likely in a new section that describes the different types of KV stores.
Yeah, that's a nice example of how we can create read-only KV stores from almost any file. Those files are just fancy CSV files (they use tab as the delimiter, so technically it's TSV) and this makes it relatively easy to retrieve and parse them. |
shellcromancer
left a comment
There was a problem hiding this comment.
Nice way to combine the cachine with the lookup processor proposal! Left a few comments on the semantics for the JSON KV and a few other things but overall this looks great! :)
| // | ||
| // This is optional and defaults to using no TTL when setting values into the store. | ||
| OffsetTTL int `json:"offset_ttl"` | ||
| // KVOptions determine the type of KV store used by the processor. Refer to internal/kv |
There was a problem hiding this comment.
don't think this matters since it's not exported -- check it out here https://pkg.go.dev/github.com/brexhq/substation@v0.8.0/process
Description
internal/kv)kv_storeprocessor for retrieving and putting items into any KV store, all features of the KV store interface are supportedkv_storeprocessorGetItem(required for the DynamoDB KV store)Motivation and Context
This addresses both #55 and #65 -- both use cases are abstracted into the generic KV store use case, which can be extended with support for future backends. This functionality enables this functionality / future work:
internal/ip/databaseinto KV storeHow Has This Been Tested?
Unit tests are passing and all features were locally integration tested.
Types of changes
Checklist: