Skip to content

feat: Add Lexicographical Types to condition/strings#98

Merged
jshlbrd merged 1 commit intomainfrom
jshlbrd/feat/string-condition-types
Apr 17, 2023
Merged

feat: Add Lexicographical Types to condition/strings#98
jshlbrd merged 1 commit intomainfrom
jshlbrd/feat/string-condition-types

Conversation

@jshlbrd
Copy link
Contributor

@jshlbrd jshlbrd commented Apr 17, 2023

Description

  • Adds a greater_than type to condition/strings
  • Adds a less_than type to condition/strings

Motivation and Context

Lexicographical string comparison can be useful when retroactively parsing data (e.g., during rehydration) or for validating data. These new types use the same syntax as conditions/length.

How Has This Been Tested?

Added new unit tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@jshlbrd jshlbrd marked this pull request as ready for review April 17, 2023 18:40
@jshlbrd jshlbrd requested a review from a team as a code owner April 17, 2023 18:40
@jshlbrd jshlbrd merged commit 110253b into main Apr 17, 2023
@jshlbrd jshlbrd deleted the jshlbrd/feat/string-condition-types branch April 17, 2023 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants