[jdbc] Add mssql support for scan operation #1350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
busbey
requested changes
Sep 7, 2019
Collaborator
busbey
left a comment
busbey
left a comment
There was a problem hiding this comment.
Just a few nits on copyright years and this should be good to go. Will be best if someone can test mssql for the next release to contain this change
jdbc/src/main/java/com/yahoo/ycsb/db/flavors/DefaultDBFlavor.java
Outdated
Show resolved
Hide resolved
busbey
approved these changes
Sep 8, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the syntax issue SQL Server faced during scan operation.
( Microsoft SQL Server doesn't support LIMIT statement, so I added a condition to use TOP instead when we are using jdbc-binding to benchmark SQL Server scan operation. )