Commit a14fff4
committed
fix(go): prevent GC finalizer on borrowed resource handles
FromBorrowHandle for imported resources was incorrectly delegating to
FromOwnHandle, which registers a GC finalizer via runtime.AddCleanup.
This violates the Component Model specification: borrowed handles are
not owned by the callee, so the callee must not drop them. When Go's
garbage collector ran, it would drop borrowed handles through the
finalizer, corrupting the host's resource table.
Fix FromBorrowHandle to create a handle object directly without
registering a GC finalizer, preserving the correct ownership semantics.1 parent 71563e5 commit a14fff4
File tree
5 files changed
+43
-8
lines changed- crates/go/src
- tests/runtime/resource-borrow
5 files changed
+43
-8
lines changedSome generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
119 | 119 | | |
120 | 120 | | |
121 | 121 | | |
122 | | - | |
123 | | - | |
124 | | - | |
125 | | - | |
126 | | - | |
127 | | - | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2589 | 2589 | | |
2590 | 2590 | | |
2591 | 2591 | | |
2592 | | - | |
| 2592 | + | |
| 2593 | + | |
2593 | 2594 | | |
2594 | 2595 | | |
2595 | 2596 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
0 commit comments