caddyhttp: Fix logging on wildcard sites when SkipUnmappedHosts is true (#7372)

francislavoie · web-flow · commit be5f49fbeb04 · 2025-12-03T18:46:11.000Z
diff --git a/modules/caddyhttp/server.go b/modules/caddyhttp/server.go
@@ -763,9 +763,11 @@ func (s *Server) shouldLogRequest(r *http.Request) bool {
 		hostWithoutPort = r.Host
 	}
 
-	if _, ok := s.Logs.LoggerNames[hostWithoutPort]; ok {
-		// this host is mapped to a particular logger name
-		return true
+	for loggerName := range s.Logs.LoggerNames {
+		if certmagic.MatchWildcard(hostWithoutPort, loggerName) {
+			// this host is mapped to a particular logger name
+			return true
+		}
 	}
 	for _, dh := range s.Logs.SkipHosts {
 		// logging for this particular host is disabled

Original file line number	Diff line number	Diff line change
`@@ -763,9 +763,11 @@ func (s Server) shouldLogRequest(r http.Request) bool {`
`763`	`763`	`hostWithoutPort = r.Host`
`764`	`764`	`}`
`765`	`765`
`766`		`- if _, ok := s.Logs.LoggerNames[hostWithoutPort]; ok {`
`767`		`- // this host is mapped to a particular logger name`
`768`		`- return true`
	`766`	`+ for loggerName := range s.Logs.LoggerNames {`
	`767`	`+ if certmagic.MatchWildcard(hostWithoutPort, loggerName) {`
	`768`	`+ // this host is mapped to a particular logger name`
	`769`	`+ return true`
	`770`	`+ }`
`769`	`771`	`}`
`770`	`772`	`for _, dh := range s.Logs.SkipHosts {`
`771`	`773`	`// logging for this particular host is disabled`