From 5322ddfbabcad25813fd71e40312288f83e85aae Mon Sep 17 00:00:00 2001 From: "Peyman M." <16763358+peymanr34@users.noreply.github.com> Date: Sun, 28 Dec 2025 18:19:42 +0330 Subject: [PATCH] Use non-boolean self-contained arguments for dotnet publish. --- .../Unit/Tools/DotNet/Publish/DotNetPublisherTests.cs | 4 ++-- src/Cake.Common/Tools/DotNet/Publish/DotNetPublisher.cs | 5 ++--- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/Cake.Common.Tests/Unit/Tools/DotNet/Publish/DotNetPublisherTests.cs b/src/Cake.Common.Tests/Unit/Tools/DotNet/Publish/DotNetPublisherTests.cs index a051bee08c..5532ee7752 100644 --- a/src/Cake.Common.Tests/Unit/Tools/DotNet/Publish/DotNetPublisherTests.cs +++ b/src/Cake.Common.Tests/Unit/Tools/DotNet/Publish/DotNetPublisherTests.cs @@ -123,7 +123,7 @@ public void Should_Add_Settings() var result = fixture.Run(); // Then - Assert.Equal("publish --output \"/Working/artifacts\" --runtime runtime1 --framework dnxcore50 --configuration Release --version-suffix rc1 --no-build --no-dependencies --no-restore --nologo --force --self-contained true --source \"https://api.nuget.org/v3/index.json\" --verbosity minimal", result.Args); + Assert.Equal("publish --output \"/Working/artifacts\" --runtime runtime1 --framework dnxcore50 --configuration Release --version-suffix rc1 --no-build --no-dependencies --no-restore --nologo --force --self-contained --source \"https://api.nuget.org/v3/index.json\" --verbosity minimal", result.Args); } [Fact] @@ -147,7 +147,7 @@ public void Should_Add_SelfContained_False_Settings() var result = fixture.Run(); // Then - Assert.Equal("publish --output \"/Working/artifacts\" --runtime runtime1 --framework dnxcore50 --configuration Release --version-suffix rc1 --no-dependencies --no-restore --force --self-contained false --source \"https://api.nuget.org/v3/index.json\" --verbosity minimal", result.Args); + Assert.Equal("publish --output \"/Working/artifacts\" --runtime runtime1 --framework dnxcore50 --configuration Release --version-suffix rc1 --no-dependencies --no-restore --force --no-self-contained --source \"https://api.nuget.org/v3/index.json\" --verbosity minimal", result.Args); } [Fact] diff --git a/src/Cake.Common/Tools/DotNet/Publish/DotNetPublisher.cs b/src/Cake.Common/Tools/DotNet/Publish/DotNetPublisher.cs index ea4e68ca92..18421a333b 100644 --- a/src/Cake.Common/Tools/DotNet/Publish/DotNetPublisher.cs +++ b/src/Cake.Common/Tools/DotNet/Publish/DotNetPublisher.cs @@ -125,14 +125,13 @@ private ProcessArgumentBuilder GetArguments(string path, DotNetPublishSettings s // Self contained if (settings.SelfContained.HasValue) { - builder.Append("--self-contained"); if (settings.SelfContained.Value) { - builder.Append("true"); + builder.Append("--self-contained"); } else { - builder.Append("false"); + builder.Append("--no-self-contained"); } }