fix(eslint): resolve no-unused-vars errors#21309
fix(eslint): resolve no-unused-vars errors#21309adamalston wants to merge 5 commits intocarbon-design-system:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #21309 +/- ##
=======================================
Coverage 87.32% 87.32%
=======================================
Files 538 538
Lines 43521 43479 -42
Branches 6668 6681 +13
=======================================
- Hits 38003 37967 -36
+ Misses 5357 5350 -7
- Partials 161 162 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
alisonjoseph
left a comment
There was a problem hiding this comment.
Hey, so we need to leave all the code in the code connect files .figma.tsx This code isn't executed it is just displayed in Figma as example code.
Head branch was pushed to by a user without write access
|
Is there a recommended way to get Mend to pass after merging |
Partially addresses #20452
Resolved
no-unused-varsESLint errors.Changelog
Changed
no-unused-varsESLint errors.Testing / Reviewing
Reference commits: 6f63373...fdad779
I converted
forwardRefcomponents that did not use therefinto standard functional components. If that is not the desired outcome, let me know.ModalWrapperhad a deprecation warning block that was placed directly in the class body, which is invalid syntax, so the code never ran. Once fixed to actually execute, it started emitting warnings to the console in dev, causing tests that assert no warnings to fail. The fixes for that issue were to either keep the warning but gate it during tests, or remove it entirely. I went with the former. Let me know if the latter is preferable.PR Checklist
As the author of this PR, before marking ready for review, confirm you:
Updated documentation and storybook examplesWrote passing tests that cover this changeMore details can be found in the pull request guide