Skip to content

Comments

fix(eslint): resolve no-unused-vars errors#21309

Open
adamalston wants to merge 5 commits intocarbon-design-system:mainfrom
adamalston:n/a-vars
Open

fix(eslint): resolve no-unused-vars errors#21309
adamalston wants to merge 5 commits intocarbon-design-system:mainfrom
adamalston:n/a-vars

Conversation

@adamalston
Copy link
Contributor

@adamalston adamalston commented Jan 18, 2026

Partially addresses #20452

Resolved no-unused-vars ESLint errors.

Changelog

Changed

  • Resolved no-unused-vars ESLint errors.

Testing / Reviewing

Reference commits: 6f63373...fdad779

I converted forwardRef components that did not use the ref into standard functional components. If that is not the desired outcome, let me know.

ModalWrapper had a deprecation warning block that was placed directly in the class body, which is invalid syntax, so the code never ran. Once fixed to actually execute, it started emitting warnings to the console in dev, causing tests that assert no warnings to fail. The fixes for that issue were to either keep the warning but gate it during tests, or remove it entirely. I went with the former. Let me know if the latter is preferable.

PR Checklist

As the author of this PR, before marking ready for review, confirm you:

  • Reviewed every line of the diff
  • Updated documentation and storybook examples
  • Wrote passing tests that cover this change
  • Addressed any impact on accessibility (a11y)
  • Tested for cross-browser consistency
  • Validated that this code is ready for review and status checks should pass

More details can be found in the pull request guide

@codecov
Copy link

codecov bot commented Jan 18, 2026

Codecov Report

❌ Patch coverage is 93.10345% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.32%. Comparing base (fe8d96b) to head (7015ceb).

Files with missing lines Patch % Lines
...react/src/components/ModalWrapper/ModalWrapper.tsx 66.66% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #21309   +/-   ##
=======================================
  Coverage   87.32%   87.32%           
=======================================
  Files         538      538           
  Lines       43521    43479   -42     
  Branches     6668     6681   +13     
=======================================
- Hits        38003    37967   -36     
+ Misses       5357     5350    -7     
- Partials      161      162    +1     
Flag Coverage Δ
main-packages 86.94% <89.47%> (+0.11%) ⬆️
web-components 87.52% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@netlify
Copy link

netlify bot commented Jan 18, 2026

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 7015ceb
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/6998e935c886ef0008eb2381
😎 Deploy Preview https://deploy-preview-21309--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Jan 18, 2026

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 7015ceb
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-web-components/deploys/6998e93516faa50008cf4766
😎 Deploy Preview https://deploy-preview-21309--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Jan 18, 2026

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit f2a5118
🔍 Latest deploy log https://app.netlify.com/projects/carbon-elements/deploys/697262eea6812c000824e2dd
😎 Deploy Preview https://deploy-preview-21309--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, so we need to leave all the code in the code connect files .figma.tsx This code isn't executed it is just displayed in Figma as example code.

auto-merge was automatically disabled February 20, 2026 23:07

Head branch was pushed to by a user without write access

@adamalston
Copy link
Contributor Author

Is there a recommended way to get Mend to pass after merging main into a branch? It seems that whenever I do so, Mend fails. I'm not sure whether the issue is related to me, my process, or something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants