fix: address inactive text colour#90
Merged
sgoudham merged 2 commits intocatppuccin:mainfrom Jul 17, 2025
Charlie-Eeles:fix-inactive-text-colour
Merged
fix: address inactive text colour#90sgoudham merged 2 commits intocatppuccin:mainfrom Charlie-Eeles:fix-inactive-text-colour
sgoudham merged 2 commits intocatppuccin:mainfrom
Charlie-Eeles:fix-inactive-text-colour
Conversation
|
Just now seeing this. Loving the changes posted so far, seems like what you have should already resolve my ticket. However, I should have some time this weekend to get this working on the official egui demo to test it out further, so I will post an update once I do! |
sgoudham
approved these changes
Jul 17, 2025
Contributor
sgoudham
left a comment
sgoudham
left a comment
There was a problem hiding this comment.
Happy to approve based on the screenshots, thanks!
sgoudham
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #87
override_text_color is overriding all text colours, including inactive values, this means things like input hint text shows the same as actual input.
This PR removes that setting and leaves it to more specific colour setting properties, like fg_stroke.
Examples (note the input hint text of "Enter a todo...")
Mocha before:after
Macchiato before:after
Frappe before:after
Latte before:after