fix(verifier): zero-pad Adler32 checksums to 8 hex characters (#169)#169
Merged
tiborsimko merged 1 commit intocernopendata:masterfrom Dec 17, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #169 +/- ##
=======================================
Coverage 80.88% 80.88%
=======================================
Files 12 12
Lines 722 722
=======================================
Hits 584 584
Misses 138 138
🚀 New features to boost your workflow:
|
…endata#169) The hex() function does not preserve leading zeros, causing checksum verification to fail when the expected checksum value sent by the CERN Open Data portal has a leading zero (e.g. "03d9681c" vs computed "3d9681c"). This commit fixes the problem.
tiborsimko
force-pushed
the
fix-checksum-verification
branch
from
2dadcbb to
b6daa50
Compare
psaiz
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hex() function does not preserve leading zeros, causing checksum verification to fail when the expected checksum value sent by the CERN Open Data portal has a leading zero (e.g. "03d9681c" vs computed "3d9681c"). This commit fixes the problem.